Skip to content

Commit

Permalink
Hide analysis that is not implemented
Browse files Browse the repository at this point in the history
 if there is an analysis that does not show anything in the view because it is not implemented, I do not show it in the list of available views.(tested with type Data_tree

 fixes eclipse-cdt-cloud#296

Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
  • Loading branch information
IbrahimFradj committed Jun 10, 2021
1 parent 5d4e1e9 commit 3a4afb7
Showing 1 changed file with 7 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ export class ReactAvailableViewsWidget extends React.Component<ReactAvailableVie
this._forceUpdateKey = !this._forceUpdateKey;
const key = Number(this._forceUpdateKey);
let outputsRowCount = 0;
const outputs = this.state.availableOutputDescriptors.filter(value => value.type != "DATA_TREE");
// console.log("test output render",outputs)
const outputs = this.state.availableOutputDescriptors;
if (outputs) {
outputsRowCount = outputs.length;
}
Expand Down Expand Up @@ -80,16 +79,11 @@ export class ReactAvailableViewsWidget extends React.Component<ReactAvailableVie
let outputName = '';
let outputDescription = '';
let output: OutputDescriptor | undefined;
const outputDescriptors = this.state.availableOutputDescriptors.filter(value => value.type != "DATA_TREE");
// const result = outputDescriptors.filter(value => value.type != "DATA_TREE");
// console.log("test outputDescriptors", outputDescriptors)
// console.log("test result", result)
const outputDescriptors = this.state.availableOutputDescriptors;
if (outputDescriptors && outputDescriptors.length && props.index < outputDescriptors.length) {
output = outputDescriptors[props.index];
// if(output.type != 'DATA_TREE') {
outputName = output.name;
outputDescription = output.description;
// }
outputName = output.name;
outputDescription = output.description;
}
let traceContainerClassName = 'outputs-list-container';
if (props.index === this._lastSelectedOutputIndex) {
Expand All @@ -114,10 +108,7 @@ export class ReactAvailableViewsWidget extends React.Component<ReactAvailableVie

protected getTotalHeight(): number {
let totalHeight = 0;
const outputDescriptors = this.state.availableOutputDescriptors.filter(value => value.type != "DATA_TREE");
// const result = outputDescriptors.filter(value => value.type != "DATA_TREE");

// changer avec result
const outputDescriptors = this.state.availableOutputDescriptors;
outputDescriptors?.forEach(() => totalHeight += ReactAvailableViewsWidget.ROW_HEIGHT);
return totalHeight;
}
Expand All @@ -128,14 +119,8 @@ export class ReactAvailableViewsWidget extends React.Component<ReactAvailableVie
private doHandleOutputClicked(e: React.MouseEvent<HTMLDivElement>) {
const index = Number(e.currentTarget.getAttribute('data-id'));
this._lastSelectedOutputIndex = index;
const outputs = this.state.availableOutputDescriptors.filter(value => value.type != "DATA_TREE");
// const result = outputDescriptors.filter(value => value.type != "DATA_TREE");

// ajouter result
const outputs = this.state.availableOutputDescriptors;
if (outputs && this._selectedExperiment ) {
// il reste (je ne supprime pas )
console.log(" l'index",index)
console.log("voir le type quand je clique ",outputs[index].type)
signalManager().fireExperimentSelectedSignal(this._selectedExperiment);
signalManager().fireOutputAddedSignal(new OutputAddedSignalPayload(outputs[index], this._selectedExperiment));
}
Expand Down Expand Up @@ -174,6 +159,6 @@ export class ReactAvailableViewsWidget extends React.Component<ReactAvailableVie
if (descriptors && descriptors.length) {
outputDescriptors.push(...descriptors);
}
return outputDescriptors;
return outputDescriptors.filter(value => value.type != "DATA_TREE");
}
}

0 comments on commit 3a4afb7

Please sign in to comment.