Issue #7 🎫: AddVehicleForm and AddVehiclePage components
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed imports and names. - Rename folder 'vehiclesList' to 'vehicles'. - Update vehicles slice name. - Update all vehicles-related imports. - Update vehicles reducer name in 'store.js'. - Update vehicles access in dispatches.
…cThunk' on vehicles slice
- Use try/catch to properly handle errors. - Use rejectWithValue to pass error message to the component. - Export 'fetchVehicles' thunk as no default.
- Import 'postNewVehicle' thunk and add it to the extraReducers. - Add 'addNewVehicle' reducer to update the state with the new vehicle.
- Declare 'success-color' variable. - Add textarea to the inputs group styles. - Give textarea its own styles. - Add transition to '.btn' class. - Add '.btn.form__error' and '.btn.form__success' classes.
- This is to ensure that the background color is visible on older browsers that don't support the background image or the image fails to load.
ITurres
added
enhancement
2 tasks
mahammad-mostafa
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
🏆 Approved 🏆
Well done @ITurres 👏🏻 Your branch have been approved and you can merge 📦
🥇 🥇 🥇 🥇 🥇 🥇 🥇 🥇 🥇 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary for Issue #7 Completion
Added:
/src/features/vehicles/AddVehicleForm.jsx/src/helpers/createAsyncThunk.jspending,fulfilled, andrejectedactions for a given async action./src/pages/AddVehiclePage.jsxAddVehicleFormcomponent./src/styles/features/vehicles/AddVehicleForm.scssAddVehicleFormcomponent./src/styles/pages/AddVehiclePage.scssAddVehiclePagecomponent./src/helpers/setPageTitle.jsModified:
/src/app/App.jsxAddVehiclePagecomponent.ReservationPageandAddVehiclePagecomponents in a fragment./src/app/store.jsvehiclesListreducer tovehiclesand its imports accordingly./src/features/reservations/ReservationForm.jsxvehiclesreducer has been renamed, I have updated theuseSelectorhook to reflect the change./src/features/vehicles/VehiclesList.jsxfetchVehicleshas been named imported instead of default imported.useSelectorhook has been updated to reflect the change in thevehiclesreducer name./src/features/vehicles/VehiclesThunk.jsxpostNewVehiclehas been added to thevehiclesthunk file to handle the POST request to the API./src/pages/VehiclesPage.jsxvehiclesfolder name./src/styles/index.scss$success-colorhas been added for any success messages or style related to success.textareaselector to the group of inputs and select styles..btn.form__errorselector has been moved from theReservationForm.scssfile to this file..btn.form__successselector has been added to style success messages.Renamed:
/src/features/vehiclesList/to/src/features/vehicles/vehiclesListfolder has been renamed tovehiclesto better reflect the purpose of the feature and the variety of components it contains.vehiclesListfolder has been renamed, the following files within will appear as deleted and as new files in the PR. However, the files have not been deleted, they have only been renamed./src/features/vehiclesList/VehiclesSlice.jsxto/src/features/vehicles/VehiclesSlice.jsx./src/features/vehiclesList/VehiclesThunk.jsxto/src/features/vehicles/VehiclesThunk.jsx./src/features/vehiclesList/SplideCarousel.jsxto `/src/features/vehicles/SplideCarousel.jsx/src/features/vehiclesList/VehiclesList.jsxto/src/features/vehicles/VehiclesList.jsx.Deleted:
/src/styles/features/reservations/ReservationForm.scss.btn.form__errorselector from this file since it will be moved to theindex.scssfile.Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟