Fixes #204: require explicitly enabling ScalaPactPlugin on projects. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#204 for visibility |
davesmith00000
approved these changes
Jan 19, 2021
|
Thanks all -- would be great to get a release for this one as well. I would suggest a minor version bump just to respect semantic versioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
allRequirementsmeans that the plugin is automatically applied to every project in a multi-project build, which can be problematic for projects which don't need the plugin. UsingnoTriggermeans you must explicitly enable the plugin on each project with.enablePlugins(ScalaPactPlugin).Note: this should be considered a breaking change, even though it matches the documented use of the plugin, so at the very least it should be released as a minor version update.