Skip to content

Commit

Permalink
use 'CMD' rather than 'RUN' in Dockerfile to get the application goin…
Browse files Browse the repository at this point in the history 
…g when run
  • Loading branch information
@dmnTools
dmnTools committed Dec 14, 2024
1 parent 4bcfafa commit d598a37
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ RUN cd simulator/sim-dir && go mod tidy && go build -o /bin/sim sim.go exp.go

# remember to use "-v" to map in /tmp/extern
WORKDIR /pcesapps/simulator/sim-dir
RUN sim -is /tmp/extern/args/args-sim
CMD sim -is /tmp/extern/args/args-sim

Check warning on line 22 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/

0 comments on commit d598a37

Please sign in to comment.