Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: implementing Laravel's model binding on student.modality #336

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: implementing Laravel's model binding on student.modality #336

wants to merge 2 commits into from
+17 −162

Conversation

ivanlegranbizarro
Copy link
Collaborator

No description provided.

@ivanlegranbizarro ivanlegranbizarro added the Dreaming of a better world Changes you want to implement to make your project better label Oct 19, 2024
@ivanlegranbizarro ivanlegranbizarro self-assigned this Oct 19, 2024
@ivanlegranbizarro ivanlegranbizarro linked an issue Oct 19, 2024 that may be closed by this pull request
[BE] Refactor: 'student.modality' Endpoint #280
Open
@ivanlegranbizarro ivanlegranbizarro force-pushed the be-refactor-studentmodality-endpoint branch from 4595d6b to 519a36b Compare October 19, 2024 23:06
jordimorillo
jordimorillo approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jordimorillo jordimorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove that underscore in the test

tests/Feature/Controller/Student/StudentModalityControllerTest.php

class StudentModalityControllerTest extends TestCase
{
use DatabaseTransactions;

public function testStudentModalityControllerReturns_200StatusForValidStudentUuidWithModality():void
public function testStudentModalityControllerReturns_200StatusForValidStudentUuidWithModality(): void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the underscore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordimorillo jordimorillo jordimorillo approved these changes

@StephaneCarteaux StephaneCarteaux StephaneCarteaux approved these changes

@diegochiola diegochiola Awaiting requested review from diegochiola

@Amanda457 Amanda457 Awaiting requested review from Amanda457

@omgchyah omgchyah Awaiting requested review from omgchyah

@GabrielCLuque GabrielCLuque Awaiting requested review from GabrielCLuque

Assignees

@ivanlegranbizarro ivanlegranbizarro

Labels
Dreaming of a better world Changes you want to implement to make your project better
Projects
None yet
Milestone
Implement Laravel's model binding
Development

Successfully merging this pull request may close these issues.

[BE] Refactor: 'student.modality' Endpoint
3 participants
@ivanlegranbizarro @jordimorillo @StephaneCarteaux