325-refactor-model_binding-in-get-student_photo-endpoint #334
+43
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 325-refactor-model_binding-in-get-student_photo-endpoint
…into 325-refactor-model_binding-in-get-student_photo-endpoint
… to model binding
diegdar
requested review from
jordimorillo,
StephaneCarteaux,
ivanlegranbizarro and
Amanda457
…into 325-refactor-model_binding-in-get-student_photo-endpoint
|
|
||
| } | ||
|
|
||
| public function testCanInstantiateAnUser(): void |
There was a problem hiding this comment.
Remove the fixtures tests (only check the instance of what you are testing, if this has sense)
jordimorillo
approved these changes
Oct 21, 2024
| } | ||
|
|
||
| public function test_can_return_a_500_on_internal_server_error(): void | ||
| public function testCanReturns_404WithInvalidStudentUuid(): void |
There was a problem hiding this comment.
beware the underscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to apply Model Binding to the GET 'student.photo.get' endpoint