Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature#462v2 #597

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from
Open

Feature#462v2 #597

wants to merge 33 commits into from

Conversation

JoanCaballero
Copy link
Collaborator

Normalización de excepciones.

anagarcialainez and others added 24 commits April 15, 2024 10:29
…HandlerTest para soportar completamente los patrones reactivos.En total se han ajustado 6 métodos del GlobalExceptionHandler y 8 test asociados en GlobalExceptionHandlerTest.Todos los manejadores de excepciones ahora retornan Mono<ResponseEntity<MessageDto>> para mantener la operación asincrónica y no bloqueante.
# Conflicts:
#	itachallenge-challenge/src/main/java/com/itachallenge/challenge/controller/ChallengeController.java
# Conflicts:
#	itachallenge-challenge/src/main/java/com/itachallenge/challenge/controller/ChallengeController.java
#	itachallenge-challenge/src/main/java/com/itachallenge/challenge/exception/GlobalExceptionHandler.java
@JoanCaballero JoanCaballero linked an issue Oct 3, 2024 that may be closed by this pull request
@danidiazd danidiazd self-assigned this Oct 7, 2024
@@ -301,7 +323,7 @@
boolean validUUID = !StringUtils.isEmpty(id) && UUID_FORM.matcher(id).matches();

if (!validUUID) {
log.warn("Invalid ID format: {}", id);
log.warn("Invalid ID format.");

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarCloud
Copy link
Collaborator

@danidiazd danidiazd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Delete and Patch methods:
The behavior of the Patch method was corrected. Previously, it was functioning similarly to Delete.
Now, Patch allows updating all fields or just one field as needed.
Added update method in ChallengeService: A new update method was introduced in ChallengeService to handle both partial and full updates of challenges.
Improved log data handling for security: Adjustments were made to ensure that user-controlled data, such as IDs or parameters, are no longer logged, addressing potential security concerns and preventing exposure of sensitive information.

Copy link

sonarcloud bot commented Oct 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: normalización de Exceptions
5 participants