DataSetInfo parser #175
Merged
DataSetInfo parser #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 58.70% (diff: 91.61%)@@ master #175 diff @@
==========================================
Files 59 60 +1
Lines 1755 1862 +107
Methods 1673 1780 +107
Messages 0 0
Branches 82 82
==========================================
+ Hits 995 1093 +98
- Misses 760 769 +9
Partials 0 0
|
|
|
||
| implicit val intervalFormat: Format[Interval] = new Format[Interval] { | ||
| override def reads(json: JsValue) = { | ||
| val start = (json \ "start").as[DateTime] |
There was a problem hiding this comment.
to avoid the timezone related parsing problems, usually we just store the getMillis as Long other than DateTime.
There was a problem hiding this comment.
For now, I let this as Datetime like in Query as we discussed.
|
Looks good. Just had some minor comments. |
| } | ||
| } | ||
|
|
||
| implicit def tuple2Writes: Writes[Tuple2[String, String]] = Writes[(String, String)](t => Json.obj("level" -> t._1, "field" -> t._2)) |
There was a problem hiding this comment.
could you add the comment to let reader know who is using it?
| case basicField: Field => JsObject(List( | ||
| "name" -> JsString(name), | ||
| "isOptional" -> JsBoolean(isOptional), | ||
| "datatype" -> JsString(dataType))) |
There was a problem hiding this comment.
add the default throws in case we hit the unhandled fields?
caes any: Field => throw xxxx or simply case _ => ???
| implicit def tuple2Writes: Writes[Tuple2[String, String]] = Writes[(String, String)](t => Json.obj("level" -> t._1, "field" -> t._2)) | ||
|
|
||
| def parseLevels(levelSeq: Seq[Map[String, String]]): Seq[(String, String)] = { | ||
| levelSeq.map { | ||
| levelMap => (levelMap.get("level").getOrElse(""), levelMap.get("field").getOrElse("")) | ||
| try { |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DataSetInfo parser to and from a JSON Record
@JavierJia