Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer install to modern package toml #250

Merged
merged 15 commits into from
Oct 5, 2024

Conversation

Ragzouken
Copy link
Collaborator

@Ragzouken Ragzouken commented Oct 1, 2024

re: pypa/pip#11457

  • compile_proto now a standalone script instead of a setup.py subcommand
  • setup.py replaced with pyproject.toml
  • compile scripts now look for pyproject.toml instead of setup.py to determine which folders are packages
  • remove bld.bat in nanover-core conda package -- not clear why this is the only one with such a script

@Ragzouken Ragzouken linked an issue Oct 1, 2024 that may be closed by this pull request
@Ragzouken
Copy link
Collaborator Author

Much of the way there but the package installation doesn't work properly (in conda only?)

@Ragzouken
Copy link
Collaborator Author

The compile scripts weren't correct, but now seem to be working, now only conda packaging tests are failing I think.

@Ragzouken Ragzouken marked this pull request as draft October 2, 2024 15:53
@Ragzouken
Copy link
Collaborator Author

Just need to fix mypy CI now..

@Ragzouken Ragzouken marked this pull request as ready for review October 3, 2024 14:07
Copy link
Collaborator

@Mohamed-Dhouioui Mohamed-Dhouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the versioning for packages requirements here and the need for python>=3.12. However, since all the tests are running successfully, I am assuming that all is well. If issues arise in the future we can get back and check.

Copy link
Collaborator

@Mohamed-Dhouioui Mohamed-Dhouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that some tests are failing, The error occurs in the test test_remove_service within the file python-libraries/nanover-essd/tests/test_essd_client_server.py. The assertion was checking that a ServiceHub instance was not in a set of ServiceHub instances, but it failed because it was found in the set.

@Ragzouken could you check before merging?

@Ragzouken
Copy link
Collaborator Author

I noticed that some tests are failing, The error occurs in the test test_remove_service within the file python-libraries/nanover-essd/tests/test_essd_client_server.py. The assertion was checking that a ServiceHub instance was not in a set of ServiceHub instances, but it failed because it was found in the set.

@Ragzouken could you check before merging?

It's a recurring issue unrelated to this change.. it's irritatingly persistent #154

@Ragzouken Ragzouken merged commit 1391b5d into main Oct 5, 2024
9 checks passed
@Ragzouken Ragzouken deleted the fix/toml-dev-packages branch October 5, 2024 13:58
@Ragzouken Ragzouken mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings compiling nanover-protocol
2 participants