-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update developer install to modern package toml #250
Conversation
Much of the way there but the package installation doesn't work properly (in conda only?) |
057edc3
to
3a5a39e
Compare
f296f97
to
5c87d12
Compare
The compile scripts weren't correct, but now seem to be working, now only conda packaging tests are failing I think. |
Just need to fix mypy CI now.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the versioning for packages requirements here and the need for python>=3.12. However, since all the tests are running successfully, I am assuming that all is well. If issues arise in the future we can get back and check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that some tests are failing, The error occurs in the test test_remove_service
within the file python-libraries/nanover-essd/tests/test_essd_client_server.py
. The assertion was checking that a ServiceHub instance was not in a set of ServiceHub instances, but it failed because it was found in the set.
@Ragzouken could you check before merging?
It's a recurring issue unrelated to this change.. it's irritatingly persistent #154 |
re: pypa/pip#11457
compile_proto
now a standalone script instead of asetup.py
subcommandsetup.py
replaced withpyproject.toml
pyproject.toml
instead ofsetup.py
to determine which folders are packagesbld.bat
innanover-core
conda package -- not clear why this is the only one with such a script