Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly improve docstrings for Omni #244

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Slightly improve docstrings for Omni #244

merged 3 commits into from
Sep 30, 2024

Conversation

Ragzouken
Copy link
Collaborator

No description provided.

@Ragzouken Ragzouken marked this pull request as ready for review September 25, 2024 13:58
Mohamed-Dhouioui
Mohamed-Dhouioui requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@Mohamed-Dhouioui Mohamed-Dhouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented on the lines that might need some edits. Other than that, Nicely done!

Mohamed-Dhouioui
Mohamed-Dhouioui approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@Mohamed-Dhouioui Mohamed-Dhouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Nice job!

@Ragzouken Ragzouken merged commit 4a26cfb into main Sep 30, 2024
8 of 9 checks passed
@Ragzouken Ragzouken deleted the feature/omni-docstring-improvements branch September 30, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohamed-Dhouioui Mohamed-Dhouioui Mohamed-Dhouioui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ragzouken @Mohamed-Dhouioui