Skip to content

Commit

Permalink
Merge pull request #246 from IRL2/fix/skip-lammps-tests-windows
Browse files Browse the repository at this point in the history
Skip LAMMPS tests on windows due to crashes, lengthen ESSD service removal time, run LAMMPS tests on dynamic port
  • Loading branch information
Ragzouken authored Sep 30, 2024
2 parents 4dbd1ff + 9a20d75 commit 7909ce6
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def test_remove_service(client_server, service):
)
assert service in services
server.unregister_service(service)
time.sleep(TEST_INTERVAL_TIME)
time.sleep(TEST_SEARCH_TIME)
services = set(
client.search_for_services(
search_time=TEST_SEARCH_TIME, interval=TEST_INTERVAL_TIME
Expand Down
12 changes: 11 additions & 1 deletion python-libraries/nanover-lammps/tests/test_lammps_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
import sys


pytestmark = pytest.mark.skipif(
sys.platform == "win32",
reason=(
"These tests can break the windows test runner on github. "
"This is tracked in issue #33: "
"<https://github.com/IRL2/nanover-protocol/issues/33>."
),
)


@pytest.fixture
def simple_atom_lammps_frame():
mock = MockLammps()
Expand All @@ -16,7 +26,7 @@ def simple_atom_lammps_frame():

@pytest.fixture
def lammps_hook():
with LammpsImd() as hook:
with LammpsImd(port=0) as hook:
yield hook


Expand Down

0 comments on commit 7909ce6

Please sign in to comment.