-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable loading of metadata blocks in API tests, more sleep #9873
Conversation
Disabled because once there are new fields in the database that Solr doesn't know about, dataset creation could be prevented, or at least subsequent search operations could fail because the dataset can't be indexed.
Results: run 1 as of ea333c9Jenkins: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9873/1/display/redirect GitHub Actions: https://github.com/gdcc/api-test-runner/actions/runs/6050329427
|
This comment has been minimized.
This comment has been minimized.
Results: run 2 as of ea333c9 and 4139f70Jenkins: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9873/2/display/redirect GitHub Actions: https://github.com/gdcc/api-test-runner/actions/runs/6052363698 |
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
@pdurbin this doesn't look related? I just tested your branch on Rocky 9, and got: |
@donsizemore that one is a known issue: Over at https://github.com/gdcc/api-test-runner/blob/5e0f34127c1119cbd80148f1ec32ad561d6fca94/docker-compose-develop.yml I use this to get that test to pass:
In dataverse-ansible we do something similar: https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/b409c6aa9aa4a29c1e9660a221f19f06adca8338/tasks/dataverse-optional-settings.yml#L23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. the only two tests that use the deprecated load metadata block util have been disabled.
Any thoughts on when they might be returned?
I'd like to pick @poikilotherm's brain about why they seem to have an effect in Docker in particular, and apparently only after the Solr or JUnit upgrades. Still a mystery, I'm afraid. 😅 |
What this PR does / why we need it:
We can't ship 6.0 with failing tests.
Which issue(s) this PR closes:
Special notes for your reviewer:
During the containerization meeting yesterday we talked about why tests are failing at https://github.com/gdcc/api-test-runner . (This was about 20 minutes in at https://harvard.zoom.us/rec/share/Nsm8SZgE05wuziNoGPA9fYNCPoYH1sKqvgS7omn-nclo6qFTsAn-qu-pqF4JnFuZ.joqMRTV6SqSf5gMl ). One avenue to explore is how we load metadata blocks (added in PR #6921) but don't update the Solr schema. Is this a problem?
I disabled two tests with this note:
Disabled because once there are new fields in the database that Solr doesn't know about, dataset creation could be prevented, or at least subsequent search operations could fail because the dataset can't be indexed.
It's somewhat mysterious why GitHub Actions is more sensitive to the loading of a metadata block than Jenkins is. Jenkins can be fixed with more sleep in #9874.
See test results below.
Suggestions on how to test this:
Check Jenkins and GitHub Actions.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.