A static 404 page (9770) #9856
Merged
A static 404 page (9770) #9856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrowing errors under p6 on account of some conflict with prettyfaces rewrite. (#9770)
This comment has been minimized.
This comment has been minimized.
pdurbin
reviewed
Aug 30, 2023
src/main/webapp/404static.xhtml
Outdated
| <!DOCTYPE html> | ||
| <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html" lang="en"> | ||
| <head> | ||
| <title>Dataverse - Not Found</title> |
There was a problem hiding this comment.
I'm seeing some hard coded English on this page. Should we be using something like..
#{bundle['error.404.page.title']}
here? And other bundle entries from the old 404.xhtml?
There was a problem hiding this comment.
Sure, why not.
The words "copyright ..." etc. should be ok to stay hard-coded in English though.
| <div class="container"> | ||
| <div class="row"> | ||
| <div class="col-sm-8 small"> | ||
| <p>Copyright © 2023, The President & Fellows of Harvard College | <a href="http://best-practices.dataverse.org/harvard-policies/harvard-privacy-policy.html" target="_blank">Privacy Policy</a> |
There was a problem hiding this comment.
I guess we can't have anything dynamic like this:
value="#{settingsWrapper.get(':ApplicationPrivacyPolicyUrl')}"
…e. Replaced them with the more neutral "Dataverse Project") #9770
|
Here's what it looks like: |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This static page replaces the way-too-dynamic 404.xhtml page that's been throwing errors under p6 on account of some conflict with prettyfaces rewrite.
It's a rather confusing affair. I will add some details to the issue, spelling out just how confusing it is. Which will take more time than it took to put together this replacement page - which by itself should be a good reason to go with it.
Which issue(s) this PR closes:
Closes #9770
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: