Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Solr to 9.3.0 #9787

Merged
merged 28 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
548dd99
update Solr 8.11.1 to 9.3.0 (minus config) #9260
pdurbin Aug 14, 2023
5a68632
replace vanilla Solr 9.3.0 config with our 8.11.1 #9260
pdurbin Aug 16, 2023
10cb294
fix XSLTResponseWriter namespace and enable scripting module #9260
pdurbin Aug 16, 2023
bb01c6e
add Solr release note #9260
pdurbin Aug 16, 2023
e6928ea
Merge branch 'develop' into 9260-solr930 #9260
pdurbin Aug 18, 2023
c7e2e23
Merge branch 'develop' into 9260-solr930 #9260
pdurbin Aug 21, 2023
926e6ea
double sleep in test #9260
pdurbin Aug 22, 2023
5623503
refactor(solr): base solrconfig.xml on latest vanilla
poikilotherm Aug 23, 2023
137f319
refactor(solr): optimize schema.xml for Solr 9
poikilotherm Aug 23, 2023
fe702b9
refactor(solr,configbaker): do not copy managed-schema.xml file into …
poikilotherm Aug 23, 2023
8d37b0f
explain more about Solr modules #9260
pdurbin Aug 23, 2023
c21d8e6
Merge branch 'develop' into 9260-solr930 #9260
pdurbin Aug 23, 2023
dce0b0c
Merge branch '9260-solr930' into 9260-vanilla-solr-src
poikilotherm Aug 24, 2023
31ce7ac
Merge pull request #9826 from IQSS/9260-vanilla-solr-src
pdurbin Aug 24, 2023
e5be4be
Revert "explain more about Solr modules #9260" #9260
pdurbin Aug 24, 2023
8666472
rm scripting module, XSLTResponseWriter removed #9260
pdurbin Aug 24, 2023
022bf06
update release note, fresh index a must #9260
pdurbin Aug 24, 2023
137b1ba
delete :PublicInstall setting before and after test run #9260
pdurbin Aug 24, 2023
81490f8
update SolrJ to 9.3.0 #9260
pdurbin Aug 24, 2023
b8d0717
style(test): rename var in FilesIT.testAccessFacet to depict that sea…
poikilotherm Aug 24, 2023
585dc61
fix(test): add waiting for reindexing in timing critical test code wi…
poikilotherm Aug 24, 2023
eb10b86
doc(install): fix Solr 9.3 download links
poikilotherm Aug 24, 2023
3944cf1
9829 Use macos-latest runner for shellspec
bencomp Aug 25, 2023
76902ed
clarify supported version #9260
pdurbin Aug 28, 2023
2a74c6b
handle custom metadata blocks #9260
pdurbin Aug 28, 2023
e22e359
Merge branch 'develop' into 9260-solr930 #9260
pdurbin Aug 28, 2023
be34440
more detailed Solr release note #9260
pdurbin Aug 28, 2023
2308c10
fix reindex command #9260
pdurbin Aug 28, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
APP_IMAGE=gdcc/dataverse:unstable
POSTGRES_VERSION=13
DATAVERSE_DB_USER=dataverse
SOLR_VERSION=8.11.1
SOLR_VERSION=9.3.0
1 change: 0 additions & 1 deletion conf/solr/8.11.1/readme.md

This file was deleted.

File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -1353,7 +1353,7 @@
in Solr's conf/xslt directory. Changes to xslt files are checked for
every xsltCacheLifetimeSeconds.
-->
<queryResponseWriter name="xslt" class="solr.XSLTResponseWriter">
<queryResponseWriter name="xslt" class="solr.scripting.xslt.XSLTResponseWriter">
<int name="xsltCacheLifetimeSeconds">5</int>
</queryResponseWriter>

Expand Down
File renamed without changes.
3 changes: 3 additions & 0 deletions doc/release-notes/9260-solr930.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Solr has been upgraded to Solr 9. You should install Solr fresh and reindex.

Note that init scripts have been updated and starting Solr with -Dsolr.modules=scripting is now required.
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
# chkconfig: 35 92 08
# description: Starts and stops Apache Solr

SOLR_DIR="/usr/local/solr/solr-8.11.1"
SOLR_DIR="/usr/local/solr/solr-9.3.0"
SOLR_COMMAND="bin/solr"
SOLR_ARGS="-m 1g -j jetty.host=127.0.0.1"
SOLR_ARGS="-m 1g -j jetty.host=127.0.0.1 -Dsolr.modules=scripting"
SOLR_USER=solr

case $1 in
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ After = syslog.target network.target remote-fs.target nss-lookup.target
[Service]
User = solr
Type = forking
WorkingDirectory = /usr/local/solr/solr-8.11.1
ExecStart = /usr/local/solr/solr-8.11.1/bin/solr start -m 1g -j "jetty.host=127.0.0.1"
ExecStop = /usr/local/solr/solr-8.11.1/bin/solr stop
WorkingDirectory = /usr/local/solr/solr-9.3.0
ExecStart = /usr/local/solr/solr-9.3.0/bin/solr start -m 1g -j "jetty.host=127.0.0.1" -Dsolr.modules=scripting
ExecStop = /usr/local/solr/solr-9.3.0/bin/solr stop
LimitNOFILE=65000
LimitNPROC=65000
Restart=on-failure
Expand Down
4 changes: 2 additions & 2 deletions doc/sphinx-guides/source/admin/metadatacustomization.rst
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ the Solr schema configuration, including any enabled metadata schemas:

``curl "http://localhost:8080/api/admin/index/solr/schema"``

You can use :download:`update-fields.sh <../../../../conf/solr/8.11.1/update-fields.sh>` to easily add these to the
You can use :download:`update-fields.sh <../../../../conf/solr/9.3.0/update-fields.sh>` to easily add these to the
Solr schema you installed for your Dataverse installation.

The script needs a target XML file containing your Solr schema. (See the :doc:`/installation/prerequisites/` section of
Expand All @@ -540,7 +540,7 @@ from some place else than your Dataverse installation).
Please note that reconfigurations of your Solr index might require a re-index. Usually release notes indicate
a necessary re-index, but for your custom metadata you will need to keep track on your own.

Please note also that if you are going to make a pull request updating ``conf/solr/8.11.1/schema.xml`` with fields you have
Please note also that if you are going to make a pull request updating ``conf/solr/9.3.0/schema.xml`` with fields you have
added, you should first load all the custom metadata blocks in ``scripts/api/data/metadatablocks`` (including ones you
don't care about) to create a complete list of fields. (This might change in the future.)

Expand Down
18 changes: 9 additions & 9 deletions doc/sphinx-guides/source/developers/classic-dev-env.rst
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ On Linux, you should just install PostgreSQL using your favorite package manager
Install Solr
^^^^^^^^^^^^

`Solr <http://lucene.apache.org/solr/>`_ 8.11.1 is required.
`Solr <http://lucene.apache.org/solr/>`_ 9.3.0 is required.

To install Solr, execute the following commands:

Expand All @@ -144,29 +144,29 @@ To install Solr, execute the following commands:

``cd /usr/local/solr``

``curl -O http://archive.apache.org/dist/lucene/solr/8.11.1/solr-8.11.1.tgz``
``curl -O http://archive.apache.org/dist/lucene/solr/9.3.0/solr-9.3.0.tgz``
poikilotherm marked this conversation as resolved.
Show resolved Hide resolved

``tar xvfz solr-8.11.1.tgz``
``tar xvfz solr-9.3.0.tgz``

``cd solr-8.11.1/server/solr``
``cd solr-9.3.0/server/solr``

``cp -r configsets/_default collection1``

``curl -O https://raw.githubusercontent.com/IQSS/dataverse/develop/conf/solr/8.11.1/schema.xml``
``curl -O https://raw.githubusercontent.com/IQSS/dataverse/develop/conf/solr/9.3.0/schema.xml``

``curl -O https://raw.githubusercontent.com/IQSS/dataverse/develop/conf/solr/8.11.1/schema_dv_mdb_fields.xml``
``curl -O https://raw.githubusercontent.com/IQSS/dataverse/develop/conf/solr/9.3.0/schema_dv_mdb_fields.xml``

``mv schema*.xml collection1/conf``

``curl -O https://raw.githubusercontent.com/IQSS/dataverse/develop/conf/solr/8.11.1/solrconfig.xml``
``curl -O https://raw.githubusercontent.com/IQSS/dataverse/develop/conf/solr/9.3.0/solrconfig.xml``

``mv solrconfig.xml collection1/conf/solrconfig.xml``

``cd /usr/local/solr/solr-8.11.1``
``cd /usr/local/solr/solr-9.3.0``

(Please note that the extra jetty argument below is a security measure to limit connections to Solr to only your computer. For extra security, run a firewall.)

``bin/solr start -j "-Djetty.host=127.0.0.1"``
``bin/solr start -j "-Djetty.host=127.0.0.1 -Dsolr.modules=scripting"``

``bin/solr create_core -c collection1 -d server/solr/collection1/conf``

Expand Down
18 changes: 10 additions & 8 deletions doc/sphinx-guides/source/installation/prerequisites.rst
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ The Dataverse Software search index is powered by Solr.
Supported Versions
==================

The Dataverse Software has been tested with Solr version 8.11.1. Future releases in the 8.x series are likely to be compatible; however, this cannot be confirmed until they are officially tested. Major releases above 8.x (e.g. 9.x) are not supported.
The Dataverse Software has been tested with Solr version 9.3.0. Future releases in the 8.x series are likely to be compatible; however, this cannot be confirmed until they are officially tested. Major releases above 8.x (e.g. 9.x) are not supported.

Installing Solr
===============
Expand All @@ -174,19 +174,19 @@ Become the ``solr`` user and then download and configure Solr::

su - solr
cd /usr/local/solr
wget https://archive.apache.org/dist/lucene/solr/8.11.1/solr-8.11.1.tgz
tar xvzf solr-8.11.1.tgz
cd solr-8.11.1
wget https://archive.apache.org/dist/lucene/solr/9.3.0/solr-9.3.0.tgz
poikilotherm marked this conversation as resolved.
Show resolved Hide resolved
tar xvzf solr-9.3.0.tgz
cd solr-9.3.0
cp -r server/solr/configsets/_default server/solr/collection1

You should already have a "dvinstall.zip" file that you downloaded from https://github.com/IQSS/dataverse/releases . Unzip it into ``/tmp``. Then copy the files into place::

cp /tmp/dvinstall/schema*.xml /usr/local/solr/solr-8.11.1/server/solr/collection1/conf
cp /tmp/dvinstall/solrconfig.xml /usr/local/solr/solr-8.11.1/server/solr/collection1/conf
cp /tmp/dvinstall/schema*.xml /usr/local/solr/solr-9.3.0/server/solr/collection1/conf
cp /tmp/dvinstall/solrconfig.xml /usr/local/solr/solr-9.3.0/server/solr/collection1/conf

Note: The Dataverse Project team has customized Solr to boost results that come from certain indexed elements inside the Dataverse installation, for example prioritizing results from Dataverse collections over Datasets. If you would like to remove this, edit your ``solrconfig.xml`` and remove the ``<str name="qf">`` element and its contents. If you have ideas about how this boosting could be improved, feel free to contact us through our Google Group https://groups.google.com/forum/#!forum/dataverse-dev .

A Dataverse installation requires a change to the ``jetty.xml`` file that ships with Solr. Edit ``/usr/local/solr/solr-8.11.1/server/etc/jetty.xml`` , increasing ``requestHeaderSize`` from ``8192`` to ``102400``
A Dataverse installation requires a change to the ``jetty.xml`` file that ships with Solr. Edit ``/usr/local/solr/solr-9.3.0/server/etc/jetty.xml`` , increasing ``requestHeaderSize`` from ``8192`` to ``102400``

Solr will warn about needing to increase the number of file descriptors and max processes in a production environment but will still run with defaults. We have increased these values to the recommended levels by adding ulimit -n 65000 to the init script, and the following to ``/etc/security/limits.conf``::

Expand All @@ -205,7 +205,7 @@ Solr launches asynchronously and attempts to use the ``lsof`` binary to watch fo

Finally, you need to tell Solr to create the core "collection1" on startup::

echo "name=collection1" > /usr/local/solr/solr-8.11.1/server/solr/collection1/core.properties
echo "name=collection1" > /usr/local/solr/solr-9.3.0/server/solr/collection1/core.properties

Solr Init Script
================
Expand All @@ -226,6 +226,8 @@ For systems using init.d (like CentOS 6), download this :download:`Solr init scr
service start solr
chkconfig solr on

Please note that as of Solr 9 the following argument `to enable a module <https://solr.apache.org/guide/solr/latest/configuration-guide/solr-modules.html>`_ has been added to the init scripts: ``-Dsolr.modules=scripting``

Securing Solr
=============

Expand Down
2 changes: 2 additions & 0 deletions docker-compose-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ services:
depends_on:
- dev_solr_initializer
restart: on-failure
environment:
- SOLR_MODULES=scripting
ports:
- "8983:8983"
networks:
Expand Down
2 changes: 1 addition & 1 deletion downloads/download.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh
curl -L -O https://nexus.payara.fish/repository/payara-community/fish/payara/distributions/payara/6.2023.7/payara-6.2023.7.zip
curl -L -O https://archive.apache.org/dist/lucene/solr/8.11.1/solr-8.11.1.tgz
curl -L -O https://archive.apache.org/dist/solr/solr/9.3.0/solr-9.3.0.tgz
curl -L -O https://search.maven.org/remotecontent?filepath=org/jboss/weld/weld-osgi-bundle/2.2.10.Final/weld-osgi-bundle-2.2.10.Final-glassfish4.jar
curl -s -L http://sourceforge.net/projects/schemaspy/files/schemaspy/SchemaSpy%205.0.0/schemaSpy_5.0.0.jar/download > schemaSpy_5.0.0.jar
4 changes: 2 additions & 2 deletions modules/container-configbaker/assembly.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</fileSet>
<!-- Get our custom Solr files -->
<fileSet>
<directory>conf/solr/8.11.1</directory>
<directory>conf/solr/9.3.0</directory>
<outputDirectory>solr</outputDirectory>
</fileSet>
<!-- Get the setup scripts from the installer (selected choice only) -->
Expand Down Expand Up @@ -43,4 +43,4 @@
</excludes>
</fileSet>
</fileSets>
</assembly>
</assembly>
2 changes: 1 addition & 1 deletion modules/dataverse-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
<!-- Major system components and dependencies -->
<payara.version>6.2023.7</payara.version>
<postgresql.version>42.5.1</postgresql.version>
<solr.version>8.11.1</solr.version>
<solr.version>9.3.0</solr.version>
<aws.version>1.12.290</aws.version>
<google.cloud.version>0.177.0</google.cloud.version>

Expand Down
8 changes: 4 additions & 4 deletions scripts/installer/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ ${JHOVE_SCHEMA}: ../../conf/jhove/jhoveConfig.xsd ${INSTALLER_ZIP_DIR}
@echo copying jhove schema file
/bin/cp ../../conf/jhove/jhoveConfig.xsd ${INSTALLER_ZIP_DIR}

${SOLR_SCHEMA}: ../../conf/solr/8.11.1/schema.xml ../../conf/solr/8.11.1/update-fields.sh ${INSTALLER_ZIP_DIR}
${SOLR_SCHEMA}: ../../conf/solr/9.3.0/schema.xml ../../conf/solr/9.3.0/update-fields.sh ${INSTALLER_ZIP_DIR}
@echo copying Solr schema file
/bin/cp ../../conf/solr/8.11.1/schema.xml ../../conf/solr/8.11.1/update-fields.sh ${INSTALLER_ZIP_DIR}
/bin/cp ../../conf/solr/9.3.0/schema.xml ../../conf/solr/9.3.0/update-fields.sh ${INSTALLER_ZIP_DIR}

${SOLR_CONFIG}: ../../conf/solr/8.11.1/solrconfig.xml ${INSTALLER_ZIP_DIR}
${SOLR_CONFIG}: ../../conf/solr/9.3.0/solrconfig.xml ${INSTALLER_ZIP_DIR}
@echo copying Solr config file
/bin/cp ../../conf/solr/8.11.1/solrconfig.xml ${INSTALLER_ZIP_DIR}
/bin/cp ../../conf/solr/9.3.0/solrconfig.xml ${INSTALLER_ZIP_DIR}

${PYTHON_FILES}: README_python.txt install.py installConfig.py installAppServer.py installUtils.py requirements.txt default.config interactive.config ${INSTALLER_ZIP_DIR}
@echo copying Python installer files
Expand Down
12 changes: 6 additions & 6 deletions scripts/vagrant/setup-solr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ SOLR_USER=solr
SOLR_HOME=/usr/local/solr
mkdir $SOLR_HOME
chown $SOLR_USER:$SOLR_USER $SOLR_HOME
su $SOLR_USER -s /bin/sh -c "cp /dataverse/downloads/solr-8.11.1.tgz $SOLR_HOME"
su $SOLR_USER -s /bin/sh -c "cd $SOLR_HOME && tar xfz solr-8.11.1.tgz"
su $SOLR_USER -s /bin/sh -c "cd $SOLR_HOME/solr-8.11.1/server/solr && cp -r configsets/_default . && mv _default collection1"
su $SOLR_USER -s /bin/sh -c "cp /dataverse/conf/solr/8.11.1/schema*.xml $SOLR_HOME/solr-8.11.1/server/solr/collection1/conf/"
su $SOLR_USER -s /bin/sh -c "cp /dataverse/conf/solr/8.11.1/solrconfig.xml $SOLR_HOME/solr-8.11.1/server/solr/collection1/conf/solrconfig.xml"
su $SOLR_USER -s /bin/sh -c "cd $SOLR_HOME/solr-8.11.1 && bin/solr start && bin/solr create_core -c collection1 -d server/solr/collection1/conf/"
su $SOLR_USER -s /bin/sh -c "cp /dataverse/downloads/solr-9.3.0.tgz $SOLR_HOME"
su $SOLR_USER -s /bin/sh -c "cd $SOLR_HOME && tar xfz solr-9.3.0.tgz"
su $SOLR_USER -s /bin/sh -c "cd $SOLR_HOME/solr-9.3.0/server/solr && cp -r configsets/_default . && mv _default collection1"
su $SOLR_USER -s /bin/sh -c "cp /dataverse/conf/solr/9.3.0/schema*.xml $SOLR_HOME/solr-9.3.0/server/solr/collection1/conf/"
su $SOLR_USER -s /bin/sh -c "cp /dataverse/conf/solr/9.3.0/solrconfig.xml $SOLR_HOME/solr-9.3.0/server/solr/collection1/conf/solrconfig.xml"
su $SOLR_USER -s /bin/sh -c "cd $SOLR_HOME/solr-9.3.0 && bin/solr start -Dsolr.modules=scripting && bin/solr create_core -c collection1 -d server/solr/collection1/conf/"
cp /dataverse/doc/sphinx-guides/source/_static/installation/files/etc/init.d/solr /etc/init.d/solr
chmod 755 /etc/init.d/solr
/etc/init.d/solr stop
Expand Down
2 changes: 1 addition & 1 deletion scripts/vagrant/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
mkdir /opt/maven
mv apache-maven-3.8.2/* /opt/maven/
echo "export JAVA_HOME=/usr/lib/jvm/jre-openjdk" > /etc/profile.d/maven.sh
echo "export M2_HOME=/opt/maven" >> /etc/profile.d/maven.sh

Check warning on line 32 in scripts/vagrant/setup.sh

View workflow job for this annotation

GitHub Actions / Shellcheck

[shellcheck] reported by reviewdog 🐶 Consider using { cmd1; cmd2; } >> file instead of individual redirects. [SC2129](https://github.com/koalaman/shellcheck/wiki/SC2129) Raw Output: ./scripts/vagrant/setup.sh:32:1:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects. [SC2129](https://github.com/koalaman/shellcheck/wiki/SC2129)
echo "export MAVEN_HOME=/opt/maven" >> /etc/profile.d/maven.sh
echo "export PATH=/opt/maven/bin:${PATH}" >> /etc/profile.d/maven.sh
chmod 0755 /etc/profile.d/maven.sh
Expand All @@ -52,7 +52,7 @@
useradd $SOLR_USER || :
DOWNLOAD_DIR='/dataverse/downloads'
PAYARA_ZIP="$DOWNLOAD_DIR/payara-6.2023.7.zip"
SOLR_TGZ="$DOWNLOAD_DIR/solr-8.11.1.tgz"
SOLR_TGZ="$DOWNLOAD_DIR/solr-9.3.0.tgz"
if [ ! -f $PAYARA_ZIP ] || [ ! -f $SOLR_TGZ ]; then
echo "Couldn't find $PAYARA_ZIP or $SOLR_TGZ! Running download script...."
cd $DOWNLOAD_DIR && ./download.sh && cd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2164

Expand Down
6 changes: 3 additions & 3 deletions tests/shell/spec/update_fields_spec.sh
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
#shellcheck shell=sh

update_fields() {
../../conf/solr/8.11.1/update-fields.sh "$@"
../../conf/solr/9.3.0/update-fields.sh "$@"
}

Describe "Update fields command"

Describe "can operate on upstream data"
copyUpstreamSchema() { cp ../../conf/solr/8.11.1/schema.xml data/solr/upstream-schema.xml; }
copyUpstreamSchema() { cp ../../conf/solr/9.3.0/schema.xml data/solr/upstream-schema.xml; }
AfterAll 'copyUpstreamSchema'

Path schema-xml="../../conf/solr/8.11.1/schema.xml"
Path schema-xml="../../conf/solr/9.3.0/schema.xml"
It "needs upstream schema.xml"
The path schema-xml should be exist
End
Expand Down Expand Up @@ -115,8 +115,8 @@
End

Describe "succeeds because"
setup() { cp data/solr/minimal-schema.xml data/solr/minimal-schema-work.xml; }

Check warning on line 118 in tests/shell/spec/update_fields_spec.sh

View workflow job for this annotation

GitHub Actions / Shellcheck

[shellcheck] reported by reviewdog 🐶 Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317](https://github.com/koalaman/shellcheck/wiki/SC2317) Raw Output: ./tests/shell/spec/update_fields_spec.sh:118:17:info:Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317](https://github.com/koalaman/shellcheck/wiki/SC2317)
cleanup() { rm data/solr/minimal-schema-work.xml; }

Check warning on line 119 in tests/shell/spec/update_fields_spec.sh

View workflow job for this annotation

GitHub Actions / Shellcheck

[shellcheck] reported by reviewdog 🐶 Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317](https://github.com/koalaman/shellcheck/wiki/SC2317) Raw Output: ./tests/shell/spec/update_fields_spec.sh:119:19:info:Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317](https://github.com/koalaman/shellcheck/wiki/SC2317)
BeforeEach 'setup'
AfterEach 'cleanup'

Expand All @@ -124,7 +124,7 @@
AfterAll 'deleteUpstreamSchema'

match_content() {
grep -q "$@" "${match_content}"

Check warning on line 127 in tests/shell/spec/update_fields_spec.sh

View workflow job for this annotation

GitHub Actions / Shellcheck

[shellcheck] reported by reviewdog 🐶 Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317](https://github.com/koalaman/shellcheck/wiki/SC2317) Raw Output: ./tests/shell/spec/update_fields_spec.sh:127:9:info:Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317](https://github.com/koalaman/shellcheck/wiki/SC2317)

Check warning on line 127 in tests/shell/spec/update_fields_spec.sh

View workflow job for this annotation

GitHub Actions / Shellcheck

[shellcheck] reported by reviewdog 🐶 match_content is referenced but not assigned. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154) Raw Output: ./tests/shell/spec/update_fields_spec.sh:127:23:warning:match_content is referenced but not assigned. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154)
}

It "prints nothing when editing minimal schema"
Expand Down
Loading