5.14 Infinite loop in DDI export with tabular tag #9756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As discovered immediately after release, there is an infinite loop in the DDI export when a tabular tag exists. The fix is self explanatory.
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer:
Suggestions on how to test this: Upload a tabular file, wait for ingest. Select the file in the dataset file table. Hit the table level Edit/Metadata option and add a tabular tag. Then publish. With 5.14, this will result in a rapidly growing tmp file that will crash the machine when the ddi export starts to be generated. WIth the fix, this should not happen and you should get a ddi export.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: