remove duplicate properties keys #9718
Conversation
|
@stevenferey thanks for the pull request! I have no idea why but edu.harvard.iq.dataverse.api.FilesIT.testAccessFacet failed:
|
|
/push-image |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
FWIW: I've seen this on another PR - #9599. Not sure what it is yet. |
…dataverse into 9169-duplicate-property-key
pdurbin
added
the
Component: Code Infrastructure
| @@ -952,7 +952,6 @@ advanced.search.header.datasets=Datasets | |||
| advanced.search.header.files=Files | |||
| advanced.search.files.name.tip=The name given to identify the file. | |||
| advanced.search.files.description.tip=A summary describing the file and its variables. | |||
| advanced.search.files.persistentId.tip=The persistent identifier for the file. | |||
| advanced.search.files.persistentId=Data File Persistent ID | |||
| advanced.search.files.persistentId.tip=The unique persistent identifier for a data file, which can be a Handle or DOI in Dataverse. | |||
There was a problem hiding this comment.
Given that we now allow PermaLinks and people can add new PID types, perhaps the shorter version is better? i.e. keep line 955 and remove this one?
| @@ -961,7 +960,6 @@ advanced.search.files.variableName=Variable Name | |||
| advanced.search.files.variableName.tip=The name of the variable's column in the data frame. | |||
| advanced.search.files.variableLabel=Variable Label | |||
| advanced.search.files.variableLabel.tip=A short description of the variable. | |||
| advanced.search.datasets.persistentId.tip=The persistent identifier for the Dataset. | |||
| advanced.search.datasets.persistentId=Persistent Identifier | |||
| advanced.search.datasets.persistentId.tip=The Dataset's unique persistent identifier, either a DOI or Handle | |||
There was a problem hiding this comment.
Same idea - Given that we now allow PermaLinks and people can add new PID types, perhaps the shorter version is better? i.e. keep line 964 and remove this one?
There was a problem hiding this comment.
I think this would resolve #9740, too
There was a problem hiding this comment.
@stevenferey - Can you flip which lines are kept as requested in the comments? Assuming that's OK, we can move this forward once you're done. It will probably need a merge with develop too to pick up the v6.2 tag so the war can be built/IT tests will run.
|
@stevenferey - can you make the changes requested above so this can move forward. (If not, let us know if you're OK with the change and we can get someone else to edit.) |
Assuming the change is OK with the submitter so we can move this forward
What this PR does / why we need it:
Remove duplicate property keys from property files
Which issue(s) this PR closes:
Closes #9169
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
No
Additional documentation: