Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Logs are too chatty after #9558 was merged. See https://iqss.slack.com/archives/C010LA04BCG/p1689620939737689
Which issue(s) this PR closes:
None
Special notes for your reviewer:
Found during perf testing:
The logging was added a looong time ago: a129c9a. I assume it was just for troubleshooting.
Why is it different now that 5.14? If you look at 5.14 at https://github.com/IQSS/dataverse/blob/v5.13/src/main/java/edu/harvard/iq/dataverse/DatasetPage.java#L1871 you'll see that
if (persistentId != null) {
was the first in a series ofif else
clauses. Presumably that firstif
was executed a lot.Now instead of
} else if (this.getId() != null) {
...... we have
if (this.getId() != null) {
with noelse
so it gets executed a lot more. This change was made in 64743bf as part of this PR:Suggestions on how to test this:
In Docker, without the reduced logging, I see this when I load a dataset:
I've been testing by loading a published dataset landing page.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None.