Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More generics in Dataverse and SAVFileReader classes #931

Closed
wants to merge 4 commits into from
Closed

More generics in Dataverse and SAVFileReader classes #931

wants to merge 4 commits into from

Commits on Sep 22, 2014

  1. Add generics to instantiations in Dataverse class

    @bencomp
    bencomp committed Sep 22, 2014
    Configuration menu
    Copy the full SHA
    e84df9b View commit details
    Browse the repository at this point in the history

  2. Resolve merge conflict; use types in generic variable instantiation

    @bencomp
    bencomp committed Sep 22, 2014
    Configuration menu
    Copy the full SHA
    99c95bc View commit details
    Browse the repository at this point in the history

  3. Add types to ArrayList instantiations in SAVFileReader

    @bencomp
    bencomp committed Sep 22, 2014
    Configuration menu
    Copy the full SHA
    3f89804 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2014

  1. Add generics to many Lists; remove unused imports; add a FIXME 

    Using Eclipse I added type arguments to many variables and parameters. A few could not be changed because both `Dataverse`s and `Dataset`s are added to a raw `List`, e.g. in `DataversePage.getContents()`. I added a FIXME there, but the same problem can be observed elsewhere. I couldn't find uses of that code.

I also let Eclipse remove unused imports, because they are easily fixed and readded if necessary.
    @bencomp
    bencomp committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    51cca88 View commit details
    Browse the repository at this point in the history