-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use production date in citation for harvested dataset #8732
Use production date in citation for harvested dataset #8732
Conversation
@tcoupin from a very quick look I think we'll need some documentation. A small change to the guides would be great and lasting (more lasting than a release note). In addition, a release note fragment would be nice so we can highlight the change. Please see https://guides.dataverse.org/en/5.10.1/developers/making-releases.html#write-release-notes |
Hi @pdurbin |
@tcoupin thanks, you're probably right about the guides. I hope you don't mind but I'm using your PR to trigger a build on our Jenkins server. 😄 |
Hi @tcoupin, for this next sprint we are catching up on Community PRs. Would you mind updating/ refreshing thiis PR from develop? Thanks! |
2fff024
to
ddbd3e5
Compare
I rebase on develop branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you for the contribution. And @tcoupin, please once again update this branch with the latest from develop. Thanks!
…-harvested-dataset
What this PR does / why we need it:
Date in citation div is the "citation date" which is most of th time the publication date (the first release date) (https://guides.dataverse.org/en/latest/api/native-api.html?highlight=citationdate#set-citation-date-field-type-for-a-dataset).
But for a harvested dataset, the distribution date is used instead and this date is not always present. With oai_dc format the date tag if used as production date (when harvesting (see code) AND serving (see code)).
This PR try to use production date for harvested dataset in addition to distribution date
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: