-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DataFileCategoryService to manage data file categories configuration #8478
Added DataFileCategoryService to manage data file categories configuration #8478
Conversation
885d8ef
to
b4d8be8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @adaybujeda! This looks good. The Mock tests of the service methods are definitely appreciated.
One quick request, could you please document the new setting in doc/sphinx-guides/source/installation/config.rst
, under this section:
.. _database-settings:
Database Settings
-----------------
(this becomes https://guides.dataverse.org/en/latest/installation/config.html#id156, in the formatted version of the guide). Please use the descriptions of other settings there as a model. At a minimum, all it needs is the name of the setting (:FileCategories
), a brief explanation of what it does (overrides the default file categories...) and a command line example (the example you provided under "How to test this" would work perfectly).
Thank you again, for your first Dataverse PR! 🥇 😄
b4d8be8
to
cb27476
Compare
Thanks for the comments @landreev. I have updated the Database settings docs. |
OK, thank you. Please note that I added a simple "release note" directly to the branch: |
One last thing, could you please rename |
Thanks @landreev! I have renamed the service bean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, perfect, thank you.
I'm moving it along into QA, hopefully will be merged shortly.
Thanks @landreev 🚀 |
OK, this is the real last thing for sure: could you please sync the branch up with develop? - The QA are asking all the developers with unmerged PRs to do this manually; with the new release out and the project version having been changed in the main pom file. |
(Please add to or edit as you see fit; IQSS#8461)
5cac8bc
to
3b8d5e8
Compare
Sure @landreev. |
What this PR does / why we need it:
This is my first PR, so not sure there are other changes needed.
From the Harvard Data Commons project, we have a requirement to add a new file tag "Workflow" to the default list of Dataset file tags.
We thought that making this list configurable will provide value as well as meeting our requirements.
Which issue(s) this PR closes:
Closes #8461
Special notes for your reviewer:
N/A
Suggestions on how to test this:
To add a new list of default file tags, eg:
curl -X PUT -d 'Docs,Data,Code,Workflow' http://localhost:8080/api/admin/settings/:FileCategories
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A
Is there a release notes update needed for this change?:
Not sure
Additional documentation:
N/A