#4259 support Java 11

[qqmyers]

What this PR does / why we need it: This PR makes the changes necessary to update the Dataverse application and tests to run under Java 11. That's generally a good idea, allows us to take advantage of newer Java features, and is currently a prerequisite for #7504 and #7414 (these include a library built for Java 11). Note that running payara on Java 11 requires some jvm option changes that are in the default domain but would not be in domains upgraded per our instructions from glassfish. The changes will need to be documented for the release notes.

Which issue(s) this PR closes:

Closes #4259

Special notes for your reviewer: At the time of the original issue, it was less clear which Java version to upgrade to, but today, it looks like Java 11 (open) is widely available (e.g. default on Ubuntu 18). The primary issues seen were:

• jacoco 0.8.1 isn't J11 compatible - needed an upgrade
• Some code/tests depended upon the exact phrasing of Exception messages which changed - rewrote to not depend on the message details.
• Different JVM options needed for payara with Java 9+ - copied changes from the default payara domain (no change needed if starting a new build)
• dataverse-ansible updates (see that repo).

Suggestions on how to test this: Should be able to run Dataverse, unit and integration tests without problems on Java 11. One way to do that is with dataverse-ansible, setting the Java version to 11 and maven version to 3.6.3.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:
The following changes are needed to run with an upgraded domain.xml. They can be made using the asadmin interface or by editing the domain.xml file. Notes should include whichever method is decided on:
remove (J8 -specific):

 <jvm-options>-Djava.endorsed.dirs=/usr/local/payara5/glassfish/modules/endorsed:/usr/local/payara5/glassfish/lib/endorsed</jvm-options>
459a448
<jvm-options>-Djava.ext.dirs=${com.sun.aas.javaRoot}/lib/ext${path.separator}${com.sun.aas.javaRoot}/jre/lib/ext${path.separator}${com.sun.aas.instanceRoot}/lib/ext</jvm-options>

Add (Java 9+ specific):

 <jvm-options>[9|]--add-opens=java.base/jdk.internal.loader=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-exports=java.base/jdk.internal.ref=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.base/java.lang=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.base/java.net=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.base/java.nio=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.base/java.util=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.base/sun.nio.ch=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.management/sun.management=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.base/sun.net.www.protocol.jrt=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.base/sun.net.www.protocol.jar=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.naming/javax.naming.spi=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED</jvm-options>
<jvm-options>[9|]--add-opens=java.logging/java.util.logging=ALL-UNNAMED</jvm-options>

Additional documentation:

[donsizemore]

"Remove Java 8 profile" commit on Java 11 / Maven 3.6.3:

The instance is still up if anybody wants to poke around.

[scolapasta]

Looks good to me (one minor comment removal suggestion).

@qqmyers or @djbrooke could you add a release notes documents before we move this to QA?

[scolapasta]

this comment is no longer needed, no?

[qqmyers]

@djbrooke - the only things I think needs to be in the notes are

• that this version will require Java 11 to compile and/or run (which is good because it gets on a more modern version (with better performance and security) and allows developers to take advantage of new Java features),
• that people should install the JDK/JRE per their platform's usual methods (could provide an example for Dataverse's preferred platform?),
• that Dataverse recommends Java 11 as it has long term support (but 11+ should work), and
• that the domain.xml file in the config dir (usually /usr/local/payara5/glassfish/domains/domain1/config per our instructions) should be edited to delete the two jvm options note above (-Djava.endorsed.dirs and -Djava.ext.dirs, whatever their values) and add the other jvm options listed above, all to the <domain><configs><config name-"server-config"><java-config> element. (There is/may be a <config name=default-config"> element with jvm-options - that whole config does not appear to be used by Dataverse.)

I haven't checked but I assume there's a prerequisite entry for Java that should be updated as well? (W.r.t. guides, since starting from Payara's default domain will get you the jvm-options already, I don't think any mention of those are needed in the guide, just in upgrade instructions, so the guide change should be simple).

I can try to provide final text, but hopefully you can take the above and create release notes> I'll check to see where the guide needs updates at least.

[djbrooke]

@qqmyers thanks for the details, I'll give it a shot!

[qqmyers]

Awesome - release notes sound so natural when you write them!

[djbrooke]

@qqmyers thanks!

@scolapasta if the release notes look OK to you, can you approve so we can move to QA?

[pdurbin]

Should we also update Vagrant and docker-aio to Java 11?

[scolapasta]

Looks great. Java 11, here we come!