-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6919 Preview Tools and expanded preview options #7369
Conversation
This reverts commit 4deb30e. Fight fire with fire. Fight revert with revert.
We only run the SQL migration if the "type" column still exists on the externaltool table.
On a new installation, the logic wasn't running and haspreviewmode is being added by a previous SQL script.
I went ahead and moved it to QA per discussion in Slack. The code is the same as pull request #7311 which had already gone through code review. The only differences are:
|
@pdurbin
-When a file with preview and tou/gb is restricted, preview button goes to file landing page, no notices. Otherwise, everything appears to work fine. |
I addressed this is 505682b by hiding the preview button (the eyeball) for restricted files. We're giving @TaniaSchlatter time to give feedback on any other UI/UX issues before merging. |
NOTE: This pull request replaces pull request #7311 which was merged early and then reverted.
What this PR does / why we need it:
This pull request does two things:
Prior to this pull request, the Preview tab was only available for files that are publicly downloadable.
The way to create a "preview only" tool is to use the new "preview" type.
Note that explore tools can continue to appear under the Preview tab (on the file page) if they have hasPreviewMode set to true, as before.This was removed in 767882bWhich issue(s) this PR closes:
Closes #6919 (Preview Tools - New external tool preview type config setting, icon btn on dataset/file pgs)
Some commits have been added to address #4429 (Revise Explore Tools documentation to reflect modularity )
Special notes for your reviewer:
Stuff to notice:
Some questions I have:
Suggestions on how to test this:
The code having to do with the terms/guestbook popup was extensively reworked so it would be good to test...
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Screenshot 1: preview only example
Below is an example of a "preview only" tool. Note that the button in the Preview tab says "Open in New Window" and the tool is not present under the "Access File" dropdown.
Screenshot 2: Terms + Guestbook
Below is an example of terms and a guestbook being presented in a Preview tab. The tool happens to be an explore tool and shows up under "Explore Options" under the "Access File" dropdown.
Is there a release notes update needed for this change?:
Yes, a release note has been included.
Additional documentation:
Doc changes included.