Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7176 create dataset fix save validation #7193

Merged
merged 11 commits into from
Aug 17, 2020
Merged

Conversation

sekmiller
Copy link
Contributor

What this PR does / why we need it: Alternate fix for Create Dataset validation issue. Relies on the rsync support test being copied to the DatasetPage bean and resetting a null dataset owner to the ownerId of the page - as is done on Save.

Which issue(s) this PR closes:

Closes #7176 Create Dataset Form Validation fails on Save

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No

Is there a release notes update needed for this change?: None

Additional documentation:
None

@sekmiller sekmiller added this to the Dataverse 5 milestone Aug 12, 2020
@coveralls
Copy link

coveralls commented Aug 12, 2020

Coverage Status

Coverage decreased (-0.003%) to 19.558% when pulling 9fd1d7f on 7176-create-dataset-fix-save into 30f4c30 on develop.

@kcondon kcondon self-assigned this Aug 17, 2020
@kcondon kcondon merged commit 4d0bef6 into develop Aug 17, 2020
@kcondon kcondon deleted the 7176-create-dataset-fix-save branch August 17, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Dataset: Form validation not working on save, throws stack trace, gray screen
4 participants