Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6230 gf upgrade part deux #6796

Merged
merged 7 commits into from
Apr 7, 2020
Merged

6230 gf upgrade part deux #6796

merged 7 commits into from
Apr 7, 2020

Conversation

scolapasta
Copy link
Contributor

What this PR does / why we need it:
Fixes issues on template and guestbook pages dealing with editMode

Which issue(s) this PR closes:
Closes #6230

(though we may not want to close #6230 until #6595 testing is complete)

Special notes for your reviewer:
editMode viewparam changed to omnifaces for templates
editMode viewparam removed completely from guestbooks, as it was not used

Suggestions on how to test this:
Make sure you can add authors on templates; multiple choice questions / options on guestbook

Does this PR introduce a user interface change?:
No

Is there a release notes update needed for this change?:
No

Additional documentation:
this code change was made to work with Payara5, but is backwards compatible with Glassfish 4.1

@coveralls
Copy link

coveralls commented Apr 7, 2020

Coverage Status

Coverage remained the same at 19.661% when pulling 396e177 on 6230-gf-upgrade-part-deux into 076bc32 on develop.

</html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Couldn't tell what, if anything, changed on this line. Same with the template.xhtml file.

</html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as on guestbook.xhtml. What changed?

@kcondon kcondon assigned kcondon and unassigned sekmiller Apr 7, 2020
@kcondon
Copy link
Contributor

kcondon commented Apr 7, 2020

@scolapasta

I'm seeing this in logs when I add multiple options
5:45
[2020-04-07T17:44:39.554-0400] [glassfish 4.1] [WARNING] [] [javax.enterprise.resource.webcontainer.jsf.renderkit] [tid: _ThreadID=55 _ThreadName=jk-connector(2)] [timeMillis: 1586295879554] [levelValue: 900] [[
Unable to find component with ID questionResponseOptions in view.]]
5:48
happens every time you click the + button on response options to multiple choice questions.

Also am seeing this is logs when guestbook with multiple choice questions appear, one for each question. Otherwise it functions.

[2020-04-07T17:55:44.128-0400] [glassfish 4.1] [WARNING] [jsf.externalcontext.no.mime.type.found] [javax.enterprise.resource.webcontainer.jsf.context] [tid: _ThreadID=149 _ThreadName=jk-connector(3)] [timeMillis: 1586296544128] [levelValue: 900] [[
JSF1091: No mime type could be found for file /edu.harvard.iq.dvn.core.vdc.jsp. To resolve this, add a mime-type mapping to the applications web.xml.]]

[2020-04-07T17:55:44.130-0400] [glassfish 4.1] [WARNING] [jsf.externalcontext.no.mime.type.found] [javax.enterprise.resource.webcontainer.jsf.context] [tid: _ThreadID=149 _ThreadName=jk-connector(3)] [timeMillis: 1586296544130] [levelValue: 900] [[
JSF1091: No mime type could be found for file /edu.harvard.iq.dvn.core.vdc.jsp. To resolve this, add a mime-type mapping to the applications web.xml.]]

@kcondon kcondon assigned scolapasta and unassigned kcondon Apr 7, 2020
@scolapasta
Copy link
Contributor Author

The same thing occurs with dev branch, that is this is not introduced by this change. Since this PR isn't the cause and this allows us to get past some issues on payara5, I'd like to still merge this now.

@scolapasta scolapasta removed their assignment Apr 7, 2020
@kcondon kcondon self-assigned this Apr 7, 2020
@kcondon kcondon merged commit d04d09c into develop Apr 7, 2020
@kcondon kcondon deleted the 6230-gf-upgrade-part-deux branch April 7, 2020 22:34
@djbrooke djbrooke added this to the Dataverse 5 milestone Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Glassfish 4.1
6 participants