expose dataset ID and DOI/Handle in version response #6397 #6511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
approved these changes
Jan 14, 2020
|
We met at tech hours; general consensus was to add these flat (and not as a block for dataset, which I preferred, but only minorly). That said datasetPid should be either datasetIdentifier (since we just call it identifier in the dataset json) or datasetPersistentIdentifier. |
|
@scolapasta and I just chatted about this and decided we'll go with And we agree that some day when we ship a 2.0 of the Dataverse API we'll clean up all inconsistencies. 😄 |
|
Scratch that. @scolapasta is going to think about it some more. |
scolapasta
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Requested by an API user.
Which issue(s) this PR closes:
Closes #6397
Special notes for your reviewer:
None
Suggestions on how to test this:
Follow the curl example in the part of the Native API page I touched ("Get Version of a Dataset") and look for the following fields:
Does this PR introduce a user interface change?:
No
Is there a release notes update needed for this change?:
It's a judgement call. This is a pretty minor change.
Additional documentation:
None.