-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #5954 Uploading large files with S3 - Multipart Upload #6341
Fixed #5954 Uploading large files with S3 - Multipart Upload #6341
Conversation
@mderuijter thanks for this pull request! The code looks fine but where you planning to add anything to the guides? Do you need any help with this? Also, I noticed a failure at https://jenkins.dataverse.org//job/IQSS-Dataverse-Develop-PR/view/change-requests/job/PR-6341/lastCompletedBuild//testReport/junit/edu.harvard.iq.dataverse.api/AccessIT/AccessIT/ but I'm pretty sure this is because your branch is a little behind the "develop" branch. If you merge the latest from "develop" into your branch, you'll pick up pull request #6334, which should fix that error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a comment I mentioned that some docs might be nice. 😄
…-multipart-upload-support merging latest develop with branch
Thank you @pdurbin, I was wondering what documentation to add and where to put it. A little help would be nice indeed. I've followed your instructions regarding the jenkins failure and it seems to have passed all the checks. edit: I spoke to soon, some checks were not successful |
@poikilotherm do you have the capacity to push some documentation to this branch or at least stub something out so that @mderuijter can fill in the details? @mderuijter thanks for merging the latest from develop. A new test is failing on build 2 (SwordIT.testCreateDatasetPublishDestroy) but I've seen this from time to time and I think it's unrelated to your branch: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/view/change-requests/job/PR-6341/2/ |
@mderuijter I added a note in https://github.com/mderuijter/dataverse/pull/1 which you are welcome to merge (or not). 😄 I'm moving this to QA. Thanks again! |
Hi @mderuijter @pdurbin, to activate this feature one would need s3 storage enabled and upload through either the browser or api or this intended for api use only? |
@kcondon the code change is in the S3 driver itself which is used by both the UI and the API. |
add note: S3 multipart upload support for files over 4GB #5954
Related Issues
Pull Request Checklist