add scope=file for TwoRavens external tool manifest #6203 #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I just created "hosting Dataverse external tool manifest and installation instructions on the TwoRavens website" at TwoRavens/TwoRavens#696 |
landreev
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6203 but an alternative would be to enforce what we document in the new "Building External Tools" section of the API Guide (blue emphasis below):
@TwoRavens if you're listening, you are very welcome to start hosting your own manifest file (like we ask all other external toolmakers to do). 😄 I'm happy to help explain this process and point to examples. For now I consider you grandfathered in until we pick up #4429 😄
For QA, here is the part of the doc to look at. I didn't change the text so here's the 4.16 version: http://guides.dataverse.org/en/4.16/installation/r-rapache-tworavens.html#e-enable-tworavens-button-in-dataverse