5613 add dataset fails when inherit mdb unchecked

[sekmiller]

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

• closes Add Data: Throws exception when on dataverse create, inherit metadata blocks was unchecked. #5613 Add Data: Throws exception when inherit Metadata Blocks unchecked

Pull Request Checklist

• Unit [tests][x] none
• Integration [tests][x]: None
• Deployment requirements, [x] None
• Documentation N/A
• Merged latest from "develop" [branch][x] and resolved conflicts

[dataversebot]

Can one of the admins verify this patch?

[coveralls]

Coverage remained the same at 19.489% when pulling 96ae41c on 5613-add-dataset-fails-when-inherit-mdb-unchecked into 9a67752 on develop.

[kcondon]

@sekmiller This prevents the exception but as noted in the issue, now when inherit mdb is unchecked, all mdb are checked by default, rather than the previous behavior of having all but citation unchecked by default. This seemed at the time to be unintentional and so should return to original behavior unless decided otherwise. Anyone?

[kcondon]

It was pointed out that the behavior remains consistent and what is actually happening is what mdbs remain checked are what the parent had checked. So if all were checked then all, only citation, then citation.