Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5198 update create dataverse docs #5870

Merged
merged 16 commits into from
May 22, 2019

Conversation

donsizemore
Copy link
Contributor

@donsizemore donsizemore commented May 21, 2019

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@@ -23,7 +23,7 @@ Create a Dataverse
Generates a new dataverse under ``$id``. Expects a JSON content describing the dataverse, as in the example below.
If ``$id`` is omitted, a root dataverse is created. ``$id`` can either be a dataverse id (long) or a dataverse alias (more robust). ::

POST http://$SERVER/api/dataverses/$id?key=$apiKey
``curl -H "X-Dataverse-key:$API_TOKEN" http://$SERVER/api/dataverses/$id --upload-file sample.json``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things (I'm happy to fix these if it's easier):

  • We need to add -X POST back in.
  • Let's change http://$SERVER to $SERVER_URL
  • Let's use dataverse-complete.json to match the

@coveralls
Copy link

coveralls commented May 21, 2019

Coverage Status

Coverage remained the same at 19.659% when pulling 453a4e5 on OdumInstitute:5198_update_create_dataverse_docs into aa59755 on IQSS:develop.

@kcondon kcondon self-assigned this May 22, 2019
@kcondon kcondon merged commit 2cc7d90 into IQSS:develop May 22, 2019
@pdurbin pdurbin added this to the 4.15 milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Sample create dataverse json file fails with parsing error.
5 participants