-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5198 update create dataverse docs #5870
Merged
kcondon
merged 16 commits into
IQSS:develop
from
uncch-rdmc:5198_update_create_dataverse_docs
May 22, 2019
Merged
5198 update create dataverse docs #5870
kcondon
merged 16 commits into
IQSS:develop
from
uncch-rdmc:5198_update_create_dataverse_docs
May 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don's ci trigger changes were merged
pdurbin
requested changes
May 21, 2019
@@ -23,7 +23,7 @@ Create a Dataverse | |||
Generates a new dataverse under ``$id``. Expects a JSON content describing the dataverse, as in the example below. | |||
If ``$id`` is omitted, a root dataverse is created. ``$id`` can either be a dataverse id (long) or a dataverse alias (more robust). :: | |||
|
|||
POST http://$SERVER/api/dataverses/$id?key=$apiKey | |||
``curl -H "X-Dataverse-key:$API_TOKEN" http://$SERVER/api/dataverses/$id --upload-file sample.json`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things (I'm happy to fix these if it's easier):
- We need to add -X POST back in.
- Let's change
http://$SERVER
to$SERVER_URL
- Let's use dataverse-complete.json to match the
pdurbin
approved these changes
May 21, 2019
This was referenced May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist