4660 custom analytics config #5416
Conversation
| @@ -63,7 +63,7 @@ | |||
| and !DatasetPage.dataset.deaccessioned | |||
| and DatasetPage.showComputeButton()}"> | |||
| <!-- Compute Button Group --> | |||
| <button type="button" id="computeBatch" class="btn btn-default dropdown-toggle" data-toggle="dropdown"> | |||
| <button type="button" id="computeBatch" class="btn btn-default btn-compute dropdown-toggle" data-toggle="dropdown"> | |||
There was a problem hiding this comment.
This "compute" change feels a bit unrelated but whatever. Cleanup, maybe?
| @@ -598,7 +598,7 @@ | |||
| <span class="glyphicon glyphicon-pencil"/> #{bundle['file.dataFilesTab.metadata.addBtn']} | |||
| </p:commandLink> | |||
| <div class="btn-group" jsf:rendered="#{DatasetPage.dataset.released and !DatasetPage.dataset.deaccessioned}" > | |||
| <button class="btn btn-default dropdown-toggle" type="button" styleClass="btn btn-default" data-toggle="dropdown"> | |||
| <button class="btn btn-default btn-export dropdown-toggle" type="button" styleClass="btn btn-default" data-toggle="dropdown"> | |||
There was a problem hiding this comment.
Actually, I guess all of these are cleanup?
| @@ -473,7 +473,7 @@ | |||
| <f:setPropertyActionListener target="#{sendFeedbackDialog.recipient}" value="#{DataversePage.dataverse}"/> | |||
| <span class="glyphicon glyphicon-envelope"/> #{bundle['contact.contact']} | |||
| </p:commandLink> | |||
| <p:commandLink type="button" styleClass="text-button bootstrap-button-tooltip" | |||
| <p:commandLink type="button" styleClass="text-button btn-share bootstrap-button-tooltip" | |||
|
In reply to code review comments from @pdurbin, those are not "clean up" changes to the buttons, but the addition of new style classes to end user event buttons (e.g. Contact, Share, Compute, Download...) to aid in the tracking of those events with analytics. I had added a comment to the issue regarding the inclusion of them in order to deliver on a user request which was the origin of this custom analytics issue. They were first discussed with @kcondon, who suggested I review it with @djbrooke, who then approved including it in this issue to deliver more value to our sysadmins. |
|
@mheppler my mistake. Thanks for the clarification! I see (now) the comment you're talking about: #4660 (comment) |
Related Issues
Pull Request Checklist