Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store size of the saved original in the database #5390

Merged
merged 3 commits into from
Dec 17, 2018

Conversation

landreev
Copy link
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

coveralls commented Dec 11, 2018

Coverage Status

Coverage decreased (-0.008%) to 17.669% when pulling 589a653 on 5323-original-size-for-tabular into 2a02d7c on develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the new "fixmissingoriginalsizes" API endpoint in the guides.

@@ -997,6 +997,26 @@ public Response fixMissingOriginalTypes() {

return ok(info);
}

@Path("datafiles/integrity/fixmissingoriginalsizes")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@landreev can you please document this new API endpoint in the guides?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have documented it in the Native API guide, with the other file-related API calls. Also added the release notes specific to the issue (doc/release-notes/5323-saved-original-size).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(thanks :)

@kcondon kcondon merged commit 0b625dd into develop Dec 17, 2018
@kcondon kcondon deleted the 5323-original-size-for-tabular branch December 17, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants