Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved Schema.org JSON-LD output #5169

Merged
merged 38 commits into from
Nov 7, 2018
Merged

improved Schema.org JSON-LD output #5169

merged 38 commits into from
Nov 7, 2018

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Oct 11, 2018

connects to #4371

@pdurbin
change "author" to "creator" #4371
a6915d7 
"I think Google Dataset Search is ignoring author and prefers creator"
@coveralls
Copy link

coveralls commented Oct 11, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 16.24% when pulling 0e0b55d on 4371-schemaorg into c2dec15 on develop.

@pdurbin
assert how "keywords" works, increase code coverage #4371
fe01e80 
from 41.16% to 42.94% for DatasetVersion
@pdurbin
stop hard-coding "Dataverse" as the provider #4371
101bd81 
Use the installation brand name instead.
@pdurbin
add @id and url as persistent URL #4371
4ca8f38
@pdurbin
add funder #4371
043080d
@pdurbin
add author identifier #4371
0d260fa
@pdurbin
add spatialCoverage #4371
a84f1d1
@pdurbin
make descriptions multi-valued (backward incompatible) #4371
ab2de1a
@pdurbin
add file metadata to output #4371
4c1387a 
Also add a JVM option to hide download URLs if necessary.
@pdurbin
express author identifier as a URL #4371
217b928
@pdurbin
add second funder type: grantNumberAgency #4371
0cdbe3e
@pdurbin
assert existing citation behavior #4371
22e08c8
@pdurbin
citations now objects not strings (backward incompatible) #4371
3a6c156
@pdurbin
put spatial coverage on single line, sorted with commas #4371
354462e
@pdurbin
duplicate values in "creator" and "author" and note why #4371
24c3249
@pdurbin
add test for datePublished #4371
8c242f8
@pdurbin
add tests for temporalCoverage #4371
f312949
@pdurbin
add tests for "license" #4371
c0361f0
@pdurbin
add "publisher" as duplicate of "provider" #4371
c162e45 
Is this also an experiment?
@pdurbin
add more javadoc #4371
e0fc235
@pdurbin
note backward-incompatible changes in API Guide #4371
8760a5a
@pdurbin
list Schema.org in User Guide, links from Admin Guide #4371
e35651a
@pdurbin
add developer-oriented docs #4371
ecde23a
@pdurbin
add test for non-CC0 #4371
aecc12d
@pdurbin
fix typo and add two validation tools to list #4371
81cac6d
@pdurbin
write example JSON to disk, more real DOIs #4371
c27f10b
@pdurbin pdurbin mentioned this pull request Oct 26, 2018
Closed
@qqmyers
Copy link
Member

qqmyers commented Nov 1, 2018

W.r.t. the discussion about reloading the tsv file. From some IRC discussion with @pdurbin, I see that adding identifiers will still allow the code to match the old entries since it tries matching on name before identifier. So my concerns above are moot/don't apply.

@kcondon kcondon merged commit babe098 into develop Nov 7, 2018
@kcondon kcondon deleted the 4371-schemaorg branch November 7, 2018 16:03
@pdurbin pdurbin mentioned this pull request Nov 26, 2018
Closed
@pdurbin pdurbin mentioned this pull request Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10 - Additional Data Transfer Options
Development

Successfully merging this pull request may close these issues.
5 participants
@pdurbin @coveralls @qqmyers @matthew-a-dunlap @kcondon