Fix Solr Highlighting #4937
Merged
Fix Solr Highlighting #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-a-dunlap
commented
Aug 8, 2018
| <!-- Solved highlighting breaking after upgrade #4836. Applied to query analyzer below too: | ||
| https://stackoverflow.com/questions/26287321/solr-stemming-breaks-highlighting | ||
| Solution was to ensure original word is kept by stemmer -MAD 4.9.2 --> | ||
| <filter class="solr.KeywordRepeatFilterFactory" /> |
There was a problem hiding this comment.
The only thing that was changed was adding this keyword repeater and then one that removes duplicates. This was done in two places. For some reason this is now needed with how we do highlighting
pdurbin
approved these changes
Aug 9, 2018
Closed
pdurbin
added this to the 4.9.3 - Optional File PIDs, Initial Internationalization Work milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Pull Request Checklist