4828 - handle pre-registering providers when creating file pids #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the whitespace changes - the real change is just to set the identifier as registered and update the date prior to calling publicizeIdentifier for those providers that pre-register in two places - the first handling the files (which I've ~tested) and again in the file loop for datasets (which I haven't looked into). |
pdurbin
requested changes
Jul 13, 2018
pdurbin
requested changes
Jul 20, 2018
4828-DOI_registration_with_EZID_does_not_make_DOIs_public Conflicts: src/main/java/edu/harvard/iq/dataverse/engine/command/impl/RegisterDvObjectCommand.java
pdurbin
reviewed
Jul 24, 2018
pdurbin
reviewed
Jul 24, 2018
| // publicizeIdentifier is called | ||
| target.setIdentifierRegistered(true); | ||
| target.setGlobalIdCreateTime(new Timestamp(new Date().getTime())); | ||
| } |
There was a problem hiding this comment.
Is there a reason why the if block above is not within the doiRetString != null null check below?
There was a problem hiding this comment.
Hmm - no. Just has to happen before publicizeIdentifier is called and shouldn't happen if the doiRetString is null/doesn't match. Good catch. I'll change that and do the same in the files loop.
of https://github.com/QualitativeDataRepository/dataverse.git into 4828-DOI_registration_with_EZID_does_not_make_DOIs_public Conflicts: src/main/java/edu/harvard/iq/dataverse/engine/command/impl/RegisterDvObjectCommand.java
|
Agree with Matthew. I think this is ready for QA. |
IdServiceBean did - loading the SettingsServiceBean.Key.Protocol if the protocol parameter was null. See Issue 4828 discussion.
…n_with_EZID_does_not_make_DOIs_public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Pull Request Checklist