Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4438 add HarvestingServerIT now that 4096 is merged #4577

Merged
merged 2 commits into from
Apr 11, 2018
Merged

#4438 add HarvestingServerIT now that 4096 is merged #4577

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8a8e32
#4438 add HarvestingServerIT now that 4096 is merged
pameyer Apr 9, 2018
3d2258e
allow non-default test.baseurl from CLI argument
pameyer Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conf/docker-aio/run-test-suite.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
# This is the canonical list of which "IT" tests are expected to pass.
# Please note the "dataverse.test.baseurl" is set to run for "all-in-one" Docker environment.
mvn test -Dtest=DataversesIT,DatasetsIT,SwordIT,AdminIT,BuiltinUsersIT,UsersIT,UtilIT,ConfirmEmailIT,FileMetadataIT,FilesIT,SearchIT,InReviewWorkflowIT -Ddataverse.test.baseurl='http://localhost:8083'
mvn test -Dtest=DataversesIT,DatasetsIT,SwordIT,AdminIT,BuiltinUsersIT,UsersIT,UtilIT,ConfirmEmailIT,FileMetadataIT,FilesIT,SearchIT,InReviewWorkflowIT,HarvestingServerIT -Ddataverse.test.baseurl='http://localhost:8083'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pameyer how do you feel about making http://localhost:8083 configurable? Perhaps a different URL could be passed in as an argument?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it configurable seems reasonable. How about checking for an environmental variable ($DV_HOST), and using a default if it's not set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference for a command line argument or flag over an environment variable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pameyer how do you feel about the getopts stuff in http://guides.dataverse.org/en/4.8.6/developers/testing.html#download-files-sh-script ?