Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the dataExplorer config file and updated the external tool in… #4443

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Removed the dataExplorer config file and updated the external tool in… #4443

merged 1 commit into from
Feb 6, 2018

Conversation

kevinworthington
Copy link
Contributor

@kevinworthington kevinworthington commented Jan 29, 2018

As requested as part of Data Explorer Integration #4249 the following changes have been made:

  1. Removed the dataExplorer config file
  2. Updated the external tool instructions

Update: This is @pdurbin adding the magic syntax to the pull request description to associate pull requests with issues on Waffle:

connects to #4249

In the guides, we mention this at http://guides.dataverse.org/en/4.8.5/developers/version-control.html#make-a-pull-request but it's probably too opaque to follow.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 12.858% when pulling db4f953 on scholarsportal:4249-Data-Explorer-Installation into 976b492 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants