-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3657 tworavens as modular explore #4426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the description for the Data Explorer
Note the FIXME that this is working from the file page but not the dataset page.
Here we are differentiating between popups for TwoRavens ("explore") and popups for external tools ("externalTool").
We don't want to show explore tools for images and such until there is a use case, at which time we can add a column to the externaltool table.
Conflicts (just imports): src/main/java/edu/harvard/iq/dataverse/GuestbookResponseServiceBean.java
We haven't shipped a release with the externaltool table yet so people shouldn't have any existing data.
Closed
Changes Unknown when pulling 480cb59 on 3657-tworavens-as-modular-explore into ** on develop**. |
Also, make method names consistent within helper, methods start with "writeGuestbookAnd...".
Now that TwoRavens is an external tool, there is no guestbookResponse.fileFormat called "explore". All external tools use a format of "externalTool".
Closed
…n dataset/file pgs. [ref #3657]
Other tweaks as well.
Other tweaks. Link to current roadmap, waffle.
We were seeing "WorldMap" under the dropdown "Explore" button (good!) and a non-dropdown "Explore" button was appearing next to it (bad!). We are now making all these explore tools consistent. They are always available via the dropdown "Explore" button. No more clicking an "Explore" button and wondering which tool will launch.
pdurbin
modified the milestones:
4.9 - Persistent Identifiers for Files,
4.8.6 Modular Explore, AWS Improvements, New APIs
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to #3657