Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3657 tworavens as modular explore #4426

Merged
merged 44 commits into from
Jan 26, 2018
Merged

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jan 19, 2018

connects to #3657

pdurbin and others added 30 commits January 3, 2018 16:00
Update the description for the Data Explorer
Note the FIXME that this is working from the file page but not the
dataset page.
Here we are differentiating between popups for TwoRavens ("explore") and
popups for external tools ("externalTool").
We don't want to show explore tools for images and such until there is a
use case, at which time we can add a column to the externaltool table.
Conflicts (just imports):
src/main/java/edu/harvard/iq/dataverse/GuestbookResponseServiceBean.java
We haven't shipped a release with the externaltool table yet so people
shouldn't have any existing data.
@pdurbin pdurbin mentioned this pull request Jan 19, 2018
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 480cb59 on 3657-tworavens-as-modular-explore into ** on develop**.

Also, make method names consistent within helper, methods start with
"writeGuestbookAnd...".
Now that TwoRavens is an external tool, there is no
guestbookResponse.fileFormat called "explore". All external tools use a
format of "externalTool".
@pdurbin pdurbin mentioned this pull request Jan 22, 2018
pdurbin and others added 7 commits January 23, 2018 09:54
Other tweaks. Link to current roadmap, waffle.
We were seeing "WorldMap" under the dropdown "Explore" button (good!)
and a non-dropdown "Explore" button was appearing next to it (bad!).

We are now making all these explore tools consistent. They are always
available via the dropdown "Explore" button. No more clicking an
"Explore" button and wondering which tool will launch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants