Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1934 glassfish is installed and run as root #3991

Merged

Conversation

donsizemore
Copy link
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.534% when pulling e6d13a5 on donsizemore:1934-Glassfish-is-installed-and-run-as-root into 0252178 on IQSS:develop.

@@ -43,40 +43,53 @@ Glassfish Version 4.1 is required. There are known issues with Glassfish 4.1.1 a
Installing Glassfish
====================

**Important**: once Glassfish is installed, a new version of the Weld library (v2.2.10.SP1) must be downloaded and installed. This fixes a serious issue in the library supplied with Glassfish 4.1 ( see https://github.com/IQSS/dataverse/issues/647 for details). Please note that if you plan to front Glassfish with Apache you must also patch Grizzly as explained in the :doc:`shibboleth` section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer true?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. It's just lower now

@kcondon
Copy link
Contributor

kcondon commented Jul 20, 2017

@donsizemore Can you refresh this from develop? It's still using v4.7 as a version. Plan to merge this today. Leonid had planned to leave a couple comments on your doc changes but I think otherwise fine. Thanks!

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Don,
A couple of small things:
Could you please sync up the branch with the current develop? - Then Kevin could proceed with the final QA tests (that's just our normal procedure).

Also, we noticed that the vagrant/install-dataverse.sh script sets the variable GLASSFISH_USER - but it's not being used anywhere; was it supposed to be passed to the installer script?

@donsizemore
Copy link
Contributor Author

@landreev I had intended for vagrant to install as GLASSFISH_USER but ran into permissions problems within Vagrant. I should've pulled that variable and missed it. How do things look now?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.599% when pulling 6bfede7 on donsizemore:1934-Glassfish-is-installed-and-run-as-root into f384229 on IQSS:develop.

@landreev
Copy link
Contributor

@donsizemore I left 2 comments in the issue (#1934); just realized that you no longer own it - so wasn't sure if you saw the updates.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 10.739% when pulling bd43278 on donsizemore:1934-Glassfish-is-installed-and-run-as-root into f384229 on IQSS:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 10.739% when pulling c9a0b20 on donsizemore:1934-Glassfish-is-installed-and-run-as-root into eec0037 on IQSS:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 10.739% when pulling a1cba04 on donsizemore:1934-Glassfish-is-installed-and-run-as-root into eec0037 on IQSS:develop.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks!

@kcondon kcondon merged commit e564562 into IQSS:develop Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants