-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1934 glassfish is installed and run as root #3991
1934 glassfish is installed and run as root #3991
Conversation
@@ -43,40 +43,53 @@ Glassfish Version 4.1 is required. There are known issues with Glassfish 4.1.1 a | |||
Installing Glassfish | |||
==================== | |||
|
|||
**Important**: once Glassfish is installed, a new version of the Weld library (v2.2.10.SP1) must be downloaded and installed. This fixes a serious issue in the library supplied with Glassfish 4.1 ( see https://github.com/IQSS/dataverse/issues/647 for details). Please note that if you plan to front Glassfish with Apache you must also patch Grizzly as explained in the :doc:`shibboleth` section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no longer true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. It's just lower now
@donsizemore Can you refresh this from develop? It's still using v4.7 as a version. Plan to merge this today. Leonid had planned to leave a couple comments on your doc changes but I think otherwise fine. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Don,
A couple of small things:
Could you please sync up the branch with the current develop? - Then Kevin could proceed with the final QA tests (that's just our normal procedure).
Also, we noticed that the vagrant/install-dataverse.sh script sets the variable GLASSFISH_USER - but it's not being used anywhere; was it supposed to be passed to the installer script?
…-Glassfish-is-installed-and-run-as-root
@landreev I had intended for vagrant to install as GLASSFISH_USER but ran into permissions problems within Vagrant. I should've pulled that variable and missed it. How do things look now? |
@donsizemore I left 2 comments in the issue (#1934); just realized that you no longer own it - so wasn't sure if you saw the updates. |
…ts to current user
…-Glassfish-is-installed-and-run-as-root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks!
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist