Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable doclint to match pre-java8 settings and allow javadoc creatio… #3516

Merged
merged 2 commits into from
Jan 20, 2017

Conversation

pameyer
Copy link
Contributor

@pameyer pameyer commented Dec 7, 2016

RFI Checklist

Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.

1. Related Issues

List and link to the issues in this Pull Request.

#2513 is related, but only as much as the failures for maven to build html output from javadoc are concerned (copying javadoc elsewhere, etc are out of scope).

  • [#### build javadoc ]

javadoc behavior changed between java7 to java8 to be more strict about tags, parameters, etc. This resulted in mvn javadoc:javadoc failing with an error. This PR fixes this (aka - running mvn javadoc:javadoc from a terminal exits successfully and produces output (from @pdurbin it produced at least some output before).


2. Pull Request Checklist

  • [ NA] Functionality completed as described in FRD
  • [ NA] Dependencies, risks, assumptions in FRD addressed
  • [ NA] Unit tests completed
  • [ NA] Deployment requirements identified (e.g., SQL scripts, indexing)
  • [ NA] Documentation completed
  • [ Y] All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

…n from maven

Connects to #2513

@coveralls
Copy link

Coverage Status

Coverage remained the same at 8.709% when pulling e85d2eb on pameyer:2513-no_doc_lint into 75a4146 on IQSS:develop.

@pdurbin pdurbin mentioned this pull request Dec 21, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 8.689% when pulling 635685b on pameyer:2513-no_doc_lint into 52e9ec3 on IQSS:develop.

@kcondon kcondon merged commit 25518d4 into IQSS:develop Jan 20, 2017
@pameyer pameyer deleted the 2513-no_doc_lint branch March 7, 2017 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants