Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Files From Dataset #11230

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Feb 7, 2025

What this PR does / why we need it:
This PR adds a deleteFiles method to the native API for datasets, using PUT as the HTTP verb to match the existing delete metadata calls.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:
Note for posterity: To be able to use DELETE with a payload, Payara has to have an option set:

asadmin set
configs.config.default-config.network-config.protocols.protocol.http-listener-1.http.allow-payload-for-undefined-http-methods=true

The consensus in slack was to not use this approach, but if we decide to in the future, we'd need to include instructions to make this change in Payara.

Suggestions on how to test this:
There's an IT test that creates a dataset with files, try to delete some, publishes the dataset and then tries to delete others. It also tests using a bad fileId or datasetId or using a user w/o permissions. Those or other cases could be manually tested as well. The documentation (in the native api section) gives a curl example.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included.

Additional documentation:

asadmin set
configs.config.default-config.network-config.protocols.protocol.http-listener-1.http.allow-payload-for-undefined-http-methods=true
@coveralls
Copy link

coveralls commented Feb 7, 2025

Coverage Status

coverage: 22.746% (-0.02%) from 22.762%
when pulling 394996e on GlobalDataverseCommunityConsortium:DANS-bulk_file_delete
into 3aea148 on IQSS:develop.

@qqmyers qqmyers added Size: 3 A percentage of a sprint. 2.1 hours. GDCC: DANS related to GDCC work for DANS SPA These changes are required for the Dataverse SPA labels Feb 8, 2025
@qqmyers qqmyers marked this pull request as ready for review February 8, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GDCC: DANS related to GDCC work for DANS Size: 3 A percentage of a sprint. 2.1 hours. SPA These changes are required for the Dataverse SPA
Projects
Status: Ready for Triage
Development

Successfully merging this pull request may close these issues.

2 participants