-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explain how to customize root collection in "running in Docker" tutorial #11201
base: develop
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
@@ -19,6 +19,13 @@ echo "" | |||
echo "Setting DOI provider to \"FAKE\"..." | |||
curl -sS -X PUT -d FAKE "${DATAVERSE_URL}/api/admin/settings/:DoiProvider" | |||
|
|||
API_TOKEN=$(grep apiToken "/tmp/setup-all.sh.out" | jq ".data.apiToken" | tr -d \") | |||
export API_TOKEN | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "if file exists" here, perhaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kris-LIBIS I added the "if" in this commit: 4f8ea65
Please take a look! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it:
In Milestone F of the container proposal and in recent discussions, we've said we want people to be able to configure the alias and name of the root collection.
Which issue(s) this PR closes:
Special notes for your reviewer:
This PR is an alternative to #11196. It allows more customization.
Please feel free to discuss here or at https://dataverse.zulipchat.com/#narrow/channel/375812-containers/topic/in.20demo.2Feval.20env.2C.20configure.20root.20collection.20alias.20and.20name/near/496383414
Suggestions on how to test this:
Follow the provided instructions. Your root collection should look like this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
https://dataverse-guide--11201.org.readthedocs.build/en/11201/container/running/demo.html#root-collection-customization-alias-name-etc