IQSS/11142 show replace in file differences #11145
Merged
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: On the file page, the version table did not show when one file replaced another (it just showed No changes associated with this version. Now it shows:
![image](https://private-user-images.githubusercontent.com/6731983/401708620-5d0e5d6b-08ef-4356-b188-62ecdccb670d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNzY0MTAsIm5iZiI6MTczOTA3NjExMCwicGF0aCI6Ii82NzMxOTgzLzQwMTcwODYyMC01ZDBlNWQ2Yi0wOGVmLTQzNTYtYjE4OC02MmVjZGNjYjY3MGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMDQ0MTUwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWY5OTcxNmJlZTYwMGJiZmM0YWUzOTk0YWY1MDc2MDRkNjc0MjI0NjhiNzcyNDI4M2UzODg2ODUzZTZjZGVmNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.-_qAy5GBXBC8CLQctJOdmUWaUFDabEnPZAnCOzGNLgU)
Which issue(s) this PR closes:
Special notes for your reviewer: The fix for this was rather trivial, just turning on existing functionality by adding a details=true flag. However, in fixing that I discovered:
dataverse/src/main/webapp/file-versions.xhtml
Line 45 in 6d6a509
dataverse/src/main/webapp/file-versions.xhtml
Line 53 in 6d6a509
dataverse/src/main/webapp/file-versions.xhtml
Line 44 in 6d6a509
Suggestions on how to test this:
Create/publish a dataset with a file, replace the file, verify that the file page version table notes the change.
Add a free-form provenance note to the file, check that the save succeeds/the dataset page is still viewable, etc. (allowing free-form provenance is a flag that may need to be set on the test machine).
Does this PR introduce a user interface change? If mockups are available, please link/include them here: In the old table, a file that was replaced, and had a description change just shows as
![image](https://private-user-images.githubusercontent.com/6731983/401715704-9923aeb3-8627-421d-ab86-05063fda5007.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNzY0MTAsIm5iZiI6MTczOTA3NjExMCwicGF0aCI6Ii82NzMxOTgzLzQwMTcxNTcwNC05OTIzYWViMy04NjI3LTQyMWQtYWI4Ni0wNTA2M2ZkYTUwMDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMDQ0MTUwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjgwZDVjYzAyNjRiMjIwMDg1YTE5MWZlZmJhODk4MDdlMjkyM2EyMmIwMWQ2ZTNlMDM1OTA4MWJjZWQ0OTVkOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.EFXxt5KmUcaAJHklLO-Nz2wu4cbkKAqvevgcknsxHVI)
Is there a release notes update needed for this change?: included.
Additional documentation: