Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend getDataverse API json payload to include properties isMetadataBlockRoot and isFacetRoot #11013

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Nov 12, 2024

What this PR does / why we need it:

The JSON payload of the getDataverse endpoint has been extended to include properties isMetadataBlockRoot and isFacetRoot.

Which issue(s) this PR closes:

Suggestions on how to test this:

Since it is a minor change, a visual inspection of the code and the new assertions in the IT (which should pass on jenkins) should be enough.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

Yes, attached.

@GPortas GPortas added Size: 0.5 A percentage of a sprint. 0.35 hours SPA These changes are required for the Dataverse SPA Original size: 0.5 SPA.Q4.3 Edit Collection Page User Role: API User Makes use of APIs GREI Re-arch Issues related to the GREI Dataverse rearchitecture labels Nov 12, 2024
@GPortas GPortas marked this pull request as ready for review November 12, 2024 12:23
@coveralls
Copy link

Coverage Status

coverage: 21.858% (+0.002%) from 21.856%
when pulling 5198a9f on 11012-get-dataverse-api-ext
into 61b8046 on develop.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11012-get-dataverse-api-ext
ghcr.io/gdcc/configbaker:11012-get-dataverse-api-ext

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ofahimIQSS ofahimIQSS self-assigned this Nov 12, 2024
@ofahimIQSS
Copy link
Contributor

Performed visual inspection of code. Merging PR

@ofahimIQSS ofahimIQSS merged commit befc5a9 into develop Nov 13, 2024
19 checks passed
@ofahimIQSS ofahimIQSS deleted the 11012-get-dataverse-api-ext branch November 13, 2024 20:05
@ofahimIQSS ofahimIQSS removed their assignment Nov 13, 2024
@pdurbin pdurbin added this to the 6.5 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 0.5 Size: 0.5 A percentage of a sprint. 0.35 hours SPA.Q4.3 Edit Collection Page SPA These changes are required for the Dataverse SPA User Role: API User Makes use of APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend View Dataverse API endpoint
5 participants