Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backwards newest oldest sort order #11000

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix backwards newest oldest sort order #11000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf1f18d
fix backwards newest oldest sort order
stevenwinship Nov 4, 2024
391a249
adding release note
stevenwinship Nov 4, 2024
d8b7ed0
Merge branch 'develop' into 10742-newest-oldest-sort-order-backwards
stevenwinship Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/release-notes/10742-newest-oldest-sort-order-backwards.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Minor bug fix to UI to fix the order of the files on the Dataset Files page when ordering by Date

A fix was made to the ui to fix the ordering 'Newest' and 'Oldest' which were reversed
6 changes: 3 additions & 3 deletions src/main/webapp/filesFragment.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,24 +301,24 @@
<f:param name="folderPresort" value="#{DatasetPage.folderPresort}"/>
</h:outputLink></li>
<li><h:outputLink rel="nofollow" value="/dataset.xhtml">
<h:outputText styleClass="#{(DatasetPage.fileSortField == 'date' and (empty DatasetPage.fileSortOrder)) ? 'highlightBold' : ''}" value="#{bundle['file.results.btn.sort.option.newest']}"/>
<h:outputText styleClass="#{(DatasetPage.fileSortField == 'date' and DatasetPage.fileSortOrder == 'desc') ? 'highlightBold' : ''}" value="#{bundle['file.results.btn.sort.option.newest']}"/>
<f:param name="persistentId" value="#{DatasetPage.persistentId}"/>
<f:param name="version" value="#{DatasetPage.version}"/>
<f:param name="q" value="#{DatasetPage.fileLabelSearchTerm}"/>
<f:param name="fileTypeGroupFacet" value="#{DatasetPage.fileTypeFacet}"/>
<f:param name="fileAccess" value="#{DatasetPage.fileAccessFacet}"/>
<f:param name="fileSortField" value="date"/>
<f:param name="fileSortOrder" value="desc"/>
<f:param name="tagPresort" value="#{DatasetPage.tagPresort}"/>
</h:outputLink></li>
<li><h:outputLink rel="nofollow" value="/dataset.xhtml">
<h:outputText styleClass="#{(DatasetPage.fileSortField == 'date' and DatasetPage.fileSortOrder == 'desc') ? 'highlightBold' : ''}" value="#{bundle['file.results.btn.sort.option.oldest']}"/>
<h:outputText styleClass="#{(DatasetPage.fileSortField == 'date' and (empty DatasetPage.fileSortOrder)) ? 'highlightBold' : ''}" value="#{bundle['file.results.btn.sort.option.oldest']}"/>
<f:param name="persistentId" value="#{DatasetPage.persistentId}"/>
<f:param name="version" value="#{DatasetPage.version}"/>
<f:param name="q" value="#{DatasetPage.fileLabelSearchTerm}"/>
<f:param name="fileTypeGroupFacet" value="#{DatasetPage.fileTypeFacet}"/>
<f:param name="fileAccess" value="#{DatasetPage.fileAccessFacet}"/>
<f:param name="fileSortField" value="date"/>
<f:param name="fileSortOrder" value="desc"/>
<f:param name="tagPresort" value="#{DatasetPage.tagPresort}"/>
</h:outputLink></li>
<li><h:outputLink rel="nofollow" value="/dataset.xhtml">
Expand Down
Loading