Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes auto-select feature for dataset thumbnail optional #10816

Closed
wants to merge 1 commit into from

Conversation

landreev
Copy link
Contributor

What this PR does / why we need it:
(copy-and-paste from linked issue:)
There is a bug in 6.3 with designated dataset thumbnails that breaks collection pages. I'm not describing it in detail here since there will be a dedicated issue for it. Turning the auto-select feature off does not fully solve this problem, but it will mitigate it significantly, because most newly published datasets will not have the designated thumbnail to cause a problem.

Which issue(s) this PR closes:

Closes #10815

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

Coverage Status

coverage: 20.75% (-0.009%) from 20.759%
when pulling 832c933 on 10815-make-autoselect-thumbnail-optional
into 025b55d on develop.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10815-make-autoselect-thumbnail-optional
ghcr.io/gdcc/configbaker:10815-make-autoselect-thumbnail-optional

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@landreev
Copy link
Contributor Author

I believe I have a real fix, so I'll close this.

@landreev landreev closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Make the auto-select dataset thumbnail feature optional
2 participants