IQSS/10137-2 Add flag to remove Return To Author Reason #10655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @qqmyers! Very much appreciated! |
sekmiller
approved these changes
Jun 26, 2024
IQSS/10137-2-add_flag_to_make_reason_optional
|
FYI: I merged with develop which removes the commit within changes and I've resolved the conflict w.r.t. feature flag order. |
|
With feature flag true(disable): Default disable=false: |
IQSS/10137-2-add_flag_to_make_reason_optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Per discussion in #10137, this PR adds a FeatureFlag to be able to disable the recent addition (in v6.2) of a required reason field in the Publish/Return To Author dialog. It also applies the same flag to the api, making the submission of a reason optional in it.
Without the flag set, the PR doesn't change anything.
Which issue(s) this PR closes:
Closes
Special notes for your reviewer: Note the PR includes the changes from #10654 that should be merged soon. I can create a clean branch is needed. Otherwise, I'll wait and merge.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here: removes the reason field when the flag is set, going back to the pre v6.2 look:
Is there a release notes update needed for this change?: included
Additional documentation: docs updated