-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding sql script to convert custom license CC0 Waiver to CC0 1.0 #10634
adding sql script to convert custom license CC0 Waiver to CC0 1.0 #10634
Conversation
@@ -0,0 +1,10 @@ | |||
UPDATE termsofuseandaccess SET license_id = (SELECT license.id FROM license WHERE license.name = 'CC0 1.0'), termsofuse = 'CC0 Waiver' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
termsofuse should be null after the update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be nice to be able to find the ones changed after the fact. There are many rows with termsofuse not null with license_id set. I can change it if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - in the UI if you have something in terms of use and select a license, the terms of use are nulled. I don't think there should be a way to have a license and terms of use or related fields- the terms of use aren't displayed when a license is in use. (Terms of Access and fields related to that are fine). I'd suggest putting null in with this PR and perhaps opening an issue to address any other cases that exist (legacy and if there's a way to create new datasets with a license and terms of use we should close that hole.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to null
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it: The update from pre-v5.10 to 5.10+ adjusts the terms metadata of datasets in the installation. The datasets that have a CC0 waiver plus text in any other field in the old "Terms of Use" accordion are considered to have "custom licenses". But some datasets with CC0 waivers and no text in fields in the old "Terms of Use" accordions also appear, after the update, to have "custom licenses", such as https://doi.org/10.7910/DVN/00ROYZ and https://doi.org/10.15787/h6vv-ts37. The only text in the custom license is "CC0 waiver":
Which issue(s) this PR closes:Multiple license update turned the terms of some datasets with only CC0 licenses into "custom licenses" #9081
Closes #9081
Special notes for your reviewer:
Suggestions on how to test this: SQL Script
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: Yes. Included
Additional documentation: