Document how to update a "develop branch to develop branch" pull request #10261
Conversation
| @@ -287,4 +287,8 @@ GitHub documents how to make changes to a fork at https://help.github.com/articl | |||
|
|
|||
| ---- | |||
|
|
|||
| Develop branch and pull request | |||
| -------------------------------------------- | |||
| Please do not use your forked develop branch to push a PR and follow the `1st scenario: preparing the first pull request of Version Control Guide <https://github.com/Recherche-Data-Gouv/dataverse/blob/develop/doc/sphinx-guides/source/developers/version-control.rst>`_. | |||
There was a problem hiding this comment.
I'm confused by this link. We're already in version-control.rst. Why would we link to the file we are already in? 🤔
There was a problem hiding this comment.
I redirected to the section on git commands. I just corrected the link.
There was a problem hiding this comment.
@martinAmouzou ah, thanks, I understand now and that # thing is a good sphinx/rst trick!
Is it ok if I move what you wrote somewhere else? And add a bit more content (for maintainers like me)?
There was a problem hiding this comment.
Please, feel free to do so ;)
There was a problem hiding this comment.
@pdurbin Yeah, you can do so. thanks
pdurbin
changed the title
|
@luddaniel yes! I made a note to myself to look at this soon. |
…nch-pull-request IQSS#9508 Conflicts: doc/sphinx-guides/source/developers/version-control.rst
There was a problem hiding this comment.
@martinAmouzou I wrote what I had in mind and will go ahead and merge this. Thanks!
luddaniel
deleted the
9508-update-develop-branch-to-develop-branch-pull-request
branch
What this PR does / why we need it: This PR is to solve the issue 9508 on how to "update a develop branch to develop branch" pull request
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: The modifications are on the latest section of the doc (version-control.rst)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: No
Additional documentation:
Preview at https://dataverse-guide--10261.org.readthedocs.build/en/10261/developers/version-control.html#handing-a-pull-request-from-a-develop-branch