quiesce missing thumbnail NPE #10181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
approved these changes
Dec 12, 2023
pdurbin
approved these changes
Dec 12, 2023
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
@donsizemore can you please resolve the merge conflicts? Thanks. |
|
This fix was already added and merged in 5d6d016 as part of this PR by @stevenwinship: Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a PDF thumbnail isn't present (and won't be generated), Payara logs a 500 error.
Which issue(s) this PR closes:
Closes #10179
Special notes for your reviewer:
It's a cherry-pick.
Suggestions on how to test this:
Upload a PDF of larger filesize than the PDF thumbnail filesize threshold, and call the dataset/datafile pages or the datafile access API endpoint as pasted in the issue.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None