-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
during password reset, users asked to accept term but there is no checkbox #9326
Comments
I just wanted to add that the proper fix is probably to simply remove "Please, accept the new terms of use before continuing." That is, there's no need to add a checkbox. It wasn't there before. It reminds me of how term stuff now also pops up when password are reencrypted with a new algorithm. Here's a screenshot from https://github.com/IQSS/dataverse-security/issues/29 Again, just removing the message about terms should be the fix. I'll give this a 3. And whoever picks it up should try to reproduce it in develop first, of course. My money is on it being a bug there and not specific to Payara 6. |
FWIW: I can confirm that this is not Payara6 specific - it happens now at dataverse.harvard.edu. |
Removed Payara 6 label because the issue occurs in current branches, too. |
Does there have to be a message? Could we just remove it? Or does this message show up only when the user tried using a password that doesn't meet the requirements? |
Another possibility would be to remove the message altogether, yes. |
Looks like the PR that's in the code review column now (#9652) edits the message instead of removing it. I suspect removing it like @pdurbin wrote earlier would be better but maybe that can be reviewed after the move to the SPA. |
better message when picking a new password #9326
When resetting their password users see "Please, accept the new terms of use before continuing."
However, there is no checkbox:
Tested on the Payara server. Not sure if it's an issue in 5.12.1 or develop.
The text was updated successfully, but these errors were encountered: